convert pathspec.c to take an index parameter
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 2 repliesIn review
- v18 patches 11 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | pathspec: provide a more descriptive die messagepathspec.c | +1 | 0 replies | |
| 2/6 | submodule: add die_in_unpopulated_submodule functionbuiltin/ pathspec.c submodule.c +2 more | +36 | 0 replies | |
| 3/6 | pathspec: remove PATHSPEC_STRIP_SUBMODULE_SLASH_EXPENSIVE flagbuiltin/ builtin/ pathspec.c +3 more | +44 | 0 replies | |
| 4/6 | ls-files: prevent prune_cache from overeagerly pruning submodulesbuiltin/ | +25 | 0 replies | |
| 5/6 | pathspec: remove PATHSPEC_STRIP_SUBMODULE_SLASH_CHEAPbuiltin/ builtin/ builtin/ +2 more | +6 | 0 replies | |
| 6/6 | pathspec: convert find_pathspecs_matching_against_index to take an indexbuiltin/ builtin/ pathspec.c +1 more | +15 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/6] convert pathspec.c to take an index parameter
The main difference in v2 is that instead of piping through an index_state struct into parse_pathspec, I ripped out the logic that needed to access the index and either removed it completely if it wasn't needed anymore (stripping submodule slash) or factored it out into its own function which can be called after initializing a pathspec object (dying if a path descends into a submodule).
Brandon Williams (6):
pathspec: provide a more descriptive die message
submodule: add die_in_unpopulated_submodule function
pathspec: remove PATHSPEC_STRIP_SUBMODULE_SLASH_EXPENSIVE flag
ls-files: prevent prune_cache from overeagerly pruning submodules
pathspec: remove PATHSPEC_STRIP_SUBMODULE_SLASH_CHEAP
pathspec: convert find_pathspecs_matching_against_index to take an
index
builtin/add.c | 12 ++++-- builtin/check-ignore.c | 6 ++- builtin/ls-files.c | 31 ++++++++++++--- builtin/reset.c | 1 - builtin/rm.c | 3 +- builtin/submodule--helper.c | 3 +- pathspec.c | 86 ++++------------------------------------ pathspec.h | 25 +++++------- submodule.c | 63 +++++++++++++++++++++++++++++ submodule.h | 4 ++ t/t6134-pathspec-in-submodule.sh | 6 +-- 11 files changed, 124 insertions(+), 116 deletions(-)
Signature · 1 line
2.13.0.rc2.291.g57267f2277-goog