Skip to content

vvfat: misc fixes for read-only mode

Hervé Poussineau qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 14 repliesIn review
  2. v113 patches 11 repliesSuperseded

Changes in v2 from the cover letter

- small changes following Kevin remarks (patches 3, 5, 6)
- use g_utf8_* functions instead of ad-hock code (patches 8 and 9)
- fix a bug with filenames starting with a dot (patch 9)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13vvfat: fix qemu-img map and qemu-img convertblock/vvfat.c+1 -21 reply
2/13vvfat: replace tabs by 8 spacesblock/vvfat.c+1027 -10270 replies
3/13vvfat: fix typosblock/vvfat.c+4 -40 replies
4/13vvfat: rename useless enumeration valuesblock/vvfat.c+8 -50 replies
5/13vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dirblock/vvfat.c+43 -272 replies
6/13vvfat: fix field names in FAT12/FAT16 and FAT32 boot sectorsblock/vvfat.c+14 -70 replies
7/13vvfat: always create . and .. entries at first and in that orderblock/vvfat.c+11 -20 replies
8/13vvfat: correctly create long names for non-ASCII filenamesblock/vvfat.c+18 -200 replies
9/13vvfat: correctly create base short names for non-ASCII filenamesblock/vvfat.c+77 -282 replies
10/13vvfat: correctly generate numeric-tail of short file namesblock/vvfat.c+29 -333 replies
11/13vvfat: limit number of entries in root directory in FAT12/FAT16block/vvfat.c+17 -90 replies
12/13vvfat: handle KANJI lead byte 0xe5block/vvfat.c+7 -21 reply
13/13vvfat: change OEM name to 'MSWIN4.1'block/vvfat.c+1 -13 replies

Reviews trailers per patch

1 of 13 patches has a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/13
2/13
3/13
4/13
5/13
6/13
7/13
8/13
9/13
10/13
11/13
12/13
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 00/13] vvfat: misc fixes for read-only mode

Hi,

This patchset fixes some of issues I encountered when trying to use vvfat, and fixes bug #1599539: https://bugs.launchpad.net/qemu/+bug/1599539

Patch 1 fixes a crash when using 'qemu-img convert'.
Patches 2 to 6 are code cleanup. No functionnal changes.
Patches 7 to 13 fix problems detected by disk checking utilities in read-only mode.

With these patches, vvfat creates valid FAT volumes and can be used with QEMU disk utilities.

Read-write mode is still buggy after this patchset, but at least, I was not able to crash QEMU anymore.

Note that patch 2 doesn't pass checkpatch.pl, as it changes indentation only.

Hervé

Changes v1->v2:
- small changes following Kevin remarks (patches 3, 5, 6)
- use g_utf8_* functions instead of ad-hock code (patches 8 and 9)
- fix a bug with filenames starting with a dot (patch 9)

Hervé Poussineau (13):
vvfat: fix qemu-img map and qemu-img convert
vvfat: replace tabs by 8 spaces
vvfat: fix typos
vvfat: rename useless enumeration values
vvfat: introduce offset_to_bootsector, offset_to_fat and
offset_to_root_dir
vvfat: fix field names in FAT12/FAT16 and FAT32 boot sectors
vvfat: always create . and .. entries at first and in that order
vvfat: correctly create long names for non-ASCII filenames
vvfat: correctly create base short names for non-ASCII filenames
vvfat: correctly generate numeric-tail of short file names
vvfat: limit number of entries in root directory in FAT12/FAT16
vvfat: handle KANJI lead byte 0xe5
vvfat: change OEM name to 'MSWIN4.1'

 block/vvfat.c | 2306 ++++++++++++++++++++++++++++++---------------------------
 1 file changed, 1198 insertions(+), 1108 deletions(-)
Signature · 1 line
2.11.0