Skip to content

Improve watchdog config for arch watchdogs

Nicholas Piggin linuxppc-dev lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 7 repliesIn review 3 of 5 applied
  2. v34 patches 18 repliesSuperseded
  3. v24 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches0 repliesSuperseded

Patches in v4 3 of 5 applied

#Subject and filesSizeRepliesApplied
1/5watchdog: remove unused declarationinclude/linux/nmi.h+0 -30 repliesApplied
2/5watchdog: introduce arch_touch_nmi_watchdog()arch/blackfin/include/asm/nmi.h arch/blackfin/kernel/nmi.c arch/mn10300/include/asm/nmi.h +6 more+31 -242 repliesApplied
3/5watchdog: split up config optionsarch/Kconfig arch/powerpc/Kconfig arch/powerpc/kernel/setup_64.c +8 more+252 -1591 reply
4/5watchdog: provide watchdog_reconfigure() for arch watchdogskernel/watchdog.c+25 -42 replies
5/5powerpc/64s: implement arch-specific hardlockup watchdogarch/powerpc/Kconfig arch/powerpc/include/asm/nmi.h arch/powerpc/include/asm/smp.h +6 more+460 -250 repliesApplied

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDon ZickusBabu Moger
SeriesR-b A-b T-b R-b
1/5
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] Improve watchdog config for arch watchdogs

This is the latest series to make the hardlockup watchdog more easily replaceable by arch code. The last patch provides some justification for why we want to do this (existing sparc watchdog is another that could benefit).

Since last time, we tidied up the Kconfig approach so it was not so jumbled -- Thanks Don and Babu for help and suggestions there.

Since last posting the powerpc patch, I re-added the soft-NMI watchdog, but have it using the emergency stack so we can always avoid the process stacks when perf interrupts are soft-masked.

I'm not sure of the best strategy to merge this. The powerpc watchdog is too much to carry anywhere but powerpc tree now, and watchdog patches seem to go via Andrew...

Thanks,
Nick

Nicholas Piggin (5):
watchdog: remove unused declaration
watchdog: introduce arch_touch_nmi_watchdog()
watchdog: split up config options
watchdog: provide watchdog_reconfigure() for arch watchdogs powerpc/64s: implement arch-specific hardlockup watchdog

 arch/Kconfig                               |  23 ++
 arch/blackfin/include/asm/nmi.h            |   2 +
 arch/blackfin/kernel/nmi.c                 |   2 +-
 arch/mn10300/include/asm/nmi.h             |   2 +
 arch/mn10300/kernel/mn10300-watchdog-low.S |   8 +-
 arch/mn10300/kernel/mn10300-watchdog.c     |   2 +-
 arch/powerpc/Kconfig                       |   6 +-
 arch/powerpc/include/asm/nmi.h             |  11 +
 arch/powerpc/include/asm/smp.h             |   2 +
 arch/powerpc/kernel/Makefile               |   1 +
 arch/powerpc/kernel/exceptions-64s.S       |  30 ++-
 arch/powerpc/kernel/kvm.c                  |   7 +
 arch/powerpc/kernel/setup_64.c             |  19 --
 arch/powerpc/kernel/smp.c                  |  20 +-
 arch/powerpc/kernel/watchdog.c             | 388 +++++++++++++++++++++++++++++
 arch/sparc/include/asm/nmi.h               |   1 +
 arch/sparc/kernel/nmi.c                    |   6 +-
 arch/x86/Kconfig                           |   1 +
 arch/x86/kernel/apic/hw_nmi.c              |   2 +-
 include/linux/nmi.h                        |  57 +++--
 kernel/Makefile                            |   2 +-
 kernel/sysctl.c                            |  31 ++-
 kernel/watchdog.c                          | 268 +++++++++++++-------
 kernel/watchdog_hld.c                      |  37 +--
 lib/Kconfig.debug                          |  45 ++--
 25 files changed, 763 insertions(+), 210 deletions(-)
 create mode 100644 arch/powerpc/kernel/watchdog.c
Signature · 1 line
2.11.0