Skip to content

Add blame to libgit

Jeff Smith git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest29 patches 9 repliesIn review

Since RFC v2 patchset from the cover letter

Rebased (merged in timestamp_t changes) Reorganized to split out and group 'mechanical' changes

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/29blame: remove unneeded dependency on blob.hbuiltin/blame.c+0 -10 replies
2/29blame: move textconv_object with related functionsbuiltin.h builtin/blame.c builtin/cat-file.c +2 more+31 -300 replies
3/29blame: remove unused parametersbuiltin/blame.c+10 -150 replies
4/29blame: rename origin structure to blame_originbuiltin/blame.c+57 -570 replies
5/29blame: rename scoreboard structure to blame_scoreboardbuiltin/blame.c+29 -290 replies
6/29blame: rename origin-related functionsbuiltin/blame.c+29 -290 replies
7/29blame: rename coalesce functionbuiltin/blame.c+2 -20 replies
8/29blame: rename ent_score functionbuiltin/blame.c+7 -70 replies
9/29blame: rename nth_line functionbuiltin/blame.c+8 -80 replies
10/29blame: move stat counters to scoreboardbuiltin/blame.c+17 -170 replies
11/29blame: move copy/move thresholds to scoreboardbuiltin/blame.c+23 -180 replies
12/29blame: move contents_from to scoreboardbuiltin/blame.c+4 -00 replies
13/29blame: move reverse flag to scoreboardbuiltin/blame.c+14 -90 replies
14/29blame: move show_root flag to scoreboardbuiltin/blame.c+4 -10 replies
15/29blame: move xdl_opts flags to scoreboardbuiltin/blame.c+5 -30 replies
16/29blame: move no_whole_file_rename flag to scoreboardbuiltin/blame.c+3 -10 replies
17/29blame: make sanity_check use a callback in scoreboardbuiltin/blame.c+19 -80 replies
18/29blame: move progess updates to a scoreboard callbackbuiltin/blame.c+17 -101 reply
19/29blame: wrap blame_sort and compare_blame_finalbuiltin/blame.c+9 -80 replies
20/29blame: rework methods that determine 'final' commitbuiltin/blame.c+23 -261 reply
21/29blame: create scoreboard init functionbuiltin/blame.c+8 -30 replies
22/29blame: create scoreboard setup functionbuiltin/blame.c+101 -891 reply
23/29blame: create entry prepend functionbuiltin/blame.c+15 -101 reply
24/29blame: move core structures to headerblame.h builtin/blame.c+144 -1331 reply
25/29blame: move origin-related methods to libgitMakefile blame.c blame.h +1 more+78 -720 replies
26/29blame: move fake-commit-related methods to libgitblame.c blame.h builtin/blame.c+205 -1990 replies
27/29blame: move scoreboard-related methods to libgitblame.c blame.h builtin/blame.c+1324 -13180 replies
28/29blame: move scoreboard setup to libgitblame.c blame.h builtin/blame.c+281 -2842 replies
29/29blame: move entry prepend to libgitblame.c blame.h builtin/blame.c+18 -140 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/29] Add blame to libgit

Rather than duplicate large portions of builtin/blame.c in cgit, it would be better to shift its core functionality into libgit.a. The functionality left in builtin/blame.c mostly relates to terminal presentation.

Since RFC v2 patchset:
Rebased (merged in timestamp_t changes) Reorganized to split out and group 'mechanical' changes

Jeff Smith (29):
blame: remove unneeded dependency on blob.h
blame: move textconv_object with related functions
blame: remove unused parameters
blame: rename origin structure to blame_origin
blame: rename scoreboard structure to blame_scoreboard
blame: rename origin-related functions
blame: rename coalesce function
blame: rename ent_score function
blame: rename nth_line function
blame: move stat counters to scoreboard
blame: move copy/move thresholds to scoreboard
blame: move contents_from to scoreboard
blame: move reverse flag to scoreboard
blame: move show_root flag to scoreboard
blame: move xdl_opts flags to scoreboard
blame: move no_whole_file_rename flag to scoreboard
blame: make sanity_check use a callback in scoreboard
blame: move progess updates to a scoreboard callback
blame: wrap blame_sort and compare_blame_final
blame: rework methods that determine 'final' commit
blame: create scoreboard init function
blame: create scoreboard setup function
blame: create entry prepend function
blame: move core structures to header
blame: move origin-related methods to libgit
blame: move fake-commit-related methods to libgit
blame: move scoreboard-related methods to libgit
blame: move scoreboard setup to libgit
blame: move entry prepend to libgit

 Makefile           |    1 +
 blame.c            | 1863 +++++++++++++++++++++++++++++++++++++++++++++
 blame.h            |  175 +++++
 builtin.h          |    2 -
 builtin/blame.c    | 2130 ++--------------------------------------------------
 builtin/cat-file.c |    1 +
 diff.c             |   23 +
 diff.h             |    7 +
 8 files changed, 2143 insertions(+), 2059 deletions(-)
 create mode 100644 blame.c
 create mode 100644 blame.h
Signature · 1 line
2.9.3