Skip to content

net: another round of extack handling for routing

David Ahern netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 2 repliesIn review
  2. v16 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9net: ipv4: refactor key and length checksnet/ipv4/fib_trie.c+15 -100 replies
2/9net: ipv4: Add extack message for invalid prefix or lengthinclude/net/ip_fib.h net/ipv4/fib_frontend.c net/ipv4/fib_trie.c+17 -100 replies
3/9net: lwtunnel: Add extack to encap attr validationinclude/net/lwtunnel.h net/core/lwtunnel.c net/ipv4/fib_frontend.c +1 more+28 -131 reply
4/9net: add extack arg to lwtunnel build stateinclude/linux/netlink.h include/net/lwtunnel.h net/core/lwt_bpf.c +9 more+67 -300 replies
5/9net: Fill in extack for mpls lwt encapnet/mpls/af_mpls.c net/mpls/internal.h net/mpls/mpls_iptunnel.c+47 -160 replies
6/9net: mpls: Pull common label check into helpernet/mpls/af_mpls.c+17 -150 replies
7/9net: mpls: Add extack messages for route add and delete failuresnet/mpls/af_mpls.c net/mpls/internal.h+87 -400 replies
8/9net: mpls: Make nla_get_via in af_mpls.cnet/mpls/af_mpls.c net/mpls/internal.h+48 -500 replies
9/9net: mpls: remove unnecessary initialization of errnet/mpls/af_mpls.c+0 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 net-next 0/9] net: another round of extack handling for routing

This set focuses on passing extack through lwtunnel and MPLS with additional catches for IPv4 route add and minor cleanups in MPLS encountered passing the extack arg around.

v2
- mindful of bloat adding duplicate messages
+ refactored prefix and prefix length checks in ipv4's fib_table_insert and fib_table_del
+ refactored label check in mpls

- split mpls cleanups into 2 patches
+ move nla_get_via up in af_mpls to avoid forward declaration

David Ahern (9):
net: ipv4: refactor key and length checks
net: ipv4: Add extack message for invalid prefix or length
net: lwtunnel: Add extack to encap attr validation
net: add extack arg to lwtunnel build state
net: Fill in extack for mpls lwt encap
net: mpls: Pull common label check into helper
net: mpls: Add extack messages for route add and delete failures
net: mpls: Make nla_get_via in af_mpls.c
net: mpls: remove unnecessary initialization of err

 include/linux/netlink.h   |  10 ++
 include/net/ip_fib.h      |   3 +-
 include/net/lwtunnel.h    |  22 ++--
 net/core/lwt_bpf.c        |   5 +-
 net/core/lwtunnel.c       |  38 +++++--
 net/ipv4/fib_frontend.c   |  13 ++-
 net/ipv4/fib_lookup.h     |   3 +-
 net/ipv4/fib_semantics.c  |  20 ++--
 net/ipv4/fib_trie.c       |  34 +++---
 net/ipv4/ip_tunnel_core.c |  11 +-
 net/ipv6/ila/ila_lwt.c    |   5 +-
 net/ipv6/route.c          |   6 +-
 net/ipv6/seg6_iptunnel.c  |   5 +-
 net/mpls/af_mpls.c        | 266 +++++++++++++++++++++++++++++-----------------
 net/mpls/internal.h       |   4 +-
 net/mpls/mpls_iptunnel.c  |  17 +--
 16 files changed, 301 insertions(+), 161 deletions(-)
Signature · 1 line
2.11.0 (Apple Git-81)