Skip to content

reporting unexpected errors after (f)open

Junio C Hamano git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest13 patches 7 repliesIn review

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13git_fopen: fix a sparse 'not declared' warningcompat/fopen.c git-compat-util.h+8 -60 replies
2/13use xfopen() in more placesbisect.c builtin/am.c builtin/commit.c +7 more+13 -390 replies
3/13clone: use xfopen() instead of fopen()builtin/clone.c+1 -10 replies
4/13config.mak.uname: set FREAD_READS_DIRECTORIES for Linux and FreeBSDconfig.mak.uname t/t1308-config-set.sh+11 -00 replies
5/13config.mak.uname: set FREAD_READS_DIRECTORIES for Darwin, tooconfig.mak.uname+1 -03 replies
6/13wrapper.c: add and use warn_on_fopen_errors()config.c dir.c git-compat-util.h +2 more+20 -40 replies
7/13wrapper.c: add and use fopen_or_warn()attr.c bisect.c builtin/blame.c +12 more+43 -260 replies
8/13wrapper.c: make warn_on_inaccessible() staticgit-compat-util.h wrapper.c+5 -70 replies
9/13print errno when reporting a system call errorbuiltin/log.c rerere.c xdiff-interface.c+6 -50 replies
10/13rerere.c: move error_errno() closer to the source system callrerere.c+2 -11 reply
11/13log: fix memory leak in open_next_file()builtin/log.c+8 -40 replies
12/13wrapper: factor out is_missing_file_error()wrapper.c+15 -12 replies
13/13is_missing_file_error(): work around EINVAL on Windowswrapper.c+4 -014 replies

Reviews trailers per patch

None of the 13 patches has a Reviewed-by or Acked-by.

PatchRamsay JonesJeff King
1/13
2/13
3/13
4/13
5/13
6/13
7/13
8/13Noticed-by
9/13
10/13
11/13Noticed-by
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/13] reporting unexpected errors after (f)open

These are taken from https://github.com/pclouds/git/commits/fopen-or-warn
cf. <CACsJy8CzgHc=qe5w=FGJJ=ZU0a+JiqBrjWHV7SH3rAPKmOOKoA@mail.gmail.com> with a few bits salvaged from its v2 version.

Ramsay Jones (1):
git_fopen: fix a sparse 'not declared' warning

Nguyễn Thái Ngọc Duy (9):
use xfopen() in more places
clone: use xfopen() instead of fopen()
config.mak.uname: set FREAD_READS_DIRECTORIES for Linux and FreeBSD wrapper.c: add and use warn_on_fopen_errors()
wrapper.c: add and use fopen_or_warn()
wrapper.c: make warn_on_inaccessible() static
print errno when reporting a system call error
rerere.c: move error_errno() closer to the source system call
log: fix memory leak in open_next_file()

Junio C Hamano (3):
config.mak.uname: set FREAD_READS_DIRECTORIES for Darwin, too
wrapper: factor out is_missing_file_error() is_missing_file_error(): work around EINVAL on Windows

Patches 12 & 13 are my attempt to answer the issue the series had on Windows.
cf. <[email protected]>

 attr.c                |  7 ++-----
 bisect.c              |  7 ++-----
 builtin/am.c          |  8 ++------
 builtin/blame.c       |  2 +-
 builtin/clone.c       |  2 +-
 builtin/commit.c      |  5 +----
 builtin/fast-export.c |  4 +---
 builtin/fsck.c        |  3 +--
 builtin/log.c         | 11 ++++++++---
 builtin/merge.c       |  4 +---
 builtin/pull.c        |  3 +--
 commit.c              |  2 +-
 compat/fopen.c        |  4 ++--
 config.c              |  5 ++++-
 config.mak.uname      |  4 ++++
 diff.c                |  8 ++------
 dir.c                 |  6 +++---
 fast-import.c         |  4 +---
 git-compat-util.h     | 15 +++++++++------
 ident.c               |  8 +++-----
 remote-testsvn.c      |  8 ++------
 remote.c              |  4 ++--
 rerere.c              |  7 ++++---
 sequencer.c           |  8 ++++----
 server-info.c         |  2 +-
 t/t1308-config-set.sh | 13 ++++++++++++-
 t/t5512-ls-remote.sh  | 13 ++++++++++---
 wrapper.c             | 49 ++++++++++++++++++++++++++++++++++++++++++++-----
 wt-status.c           |  3 ++-
 xdiff-interface.c     |  4 ++--
 30 files changed, 133 insertions(+), 90 deletions(-)
Signature · 1 line
2.13.0-491-g71cfeddc25