Skip to content

hw: arm: exynos: Improvements and cleanups

Krzysztof Kozlowski qemu-arm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest9 patches 5 repliesIn review

Changes in v4 from the cover letter

1. Rebase on current master (API for shutdown changed).
2. Apply Peter's reviewed-by tag.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9hw/intc/exynos4210_gic: Use more meaningful name for local variablehw/intc/exynos4210_gic.c+6 -61 reply
2/9hw/timer/exynos4210_mct: Fix checkpatch style errorshw/timer/exynos4210_mct.c+2 -21 reply
3/9hw/timer/exynos4210_mct: Cleanup indentation and empty new lineshw/timer/exynos4210_mct.c+20 -251 reply
4/9hw/timer/exynos4210_mct: Remove unused defineshw/timer/exynos4210_mct.c+0 -30 replies
5/9hw/arm/exynos: Move DRAM initialization next boardshw/arm/exynos4210.c hw/arm/exynos4_boards.c include/hw/arm/exynos4210.h+45 -300 replies
6/9hw/arm/exynos: Declare local variables in some orderhw/arm/exynos4210.c+2 -20 replies
7/9hw/arm/exynos: Use type define instead of hard-coded a9mpcore_priv stringhw/arm/exynos4210.c+2 -10 replies
8/9hw/intc/exynos4210_gic: Constify array of combiner interruptshw/intc/exynos4210_gic.c+1 -10 replies
9/9hw/misc/exynos4210_pmu: Add support for system poweroffhw/misc/exynos4210_pmu.c+19 -11 reply

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchPeter MaydellPhilippe Mathieu-Daudé
1/9R-b R-b
2/9R-b R-b
3/9R-b R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-arm] [PATCH v4 0/9] hw: arm: exynos: Improvements and cleanups

Hi,

I split non-intrusive changes from my previous attempts [1].

This patchset contains only cleanups, minor improvements and support for power off. Power off itself will not happen because kernel will hang before trying it, on syncing IRQ works (fix for this is [2], but this will be separate).

Changes since v3:
1. Rebase on current master (API for shutdown changed).
2. Apply Peter's reviewed-by tag.

Best regards,
Krzysztof

[1] https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg04821.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg04818.html

Krzysztof Kozlowski (9):
hw/intc/exynos4210_gic: Use more meaningful name for local variable hw/timer/exynos4210_mct: Fix checkpatch style errors hw/timer/exynos4210_mct: Cleanup indentation and empty new lines hw/timer/exynos4210_mct: Remove unused defines hw/arm/exynos: Move DRAM initialization next boards hw/arm/exynos: Declare local variables in some order hw/arm/exynos: Use type define instead of hard-coded a9mpcore_priv
string
hw/intc/exynos4210_gic: Constify array of combiner interrupts hw/misc/exynos4210_pmu: Add support for system poweroff

 hw/arm/exynos4210.c         | 27 +++++-------------------
 hw/arm/exynos4_boards.c     | 50 ++++++++++++++++++++++++++++++++++++++-------
 hw/intc/exynos4210_gic.c    | 14 ++++++-------
 hw/misc/exynos4210_pmu.c    | 20 +++++++++++++++++-
 hw/timer/exynos4210_mct.c   | 50 +++++++++++++++++++--------------------------
 include/hw/arm/exynos4210.h |  5 +----
 6 files changed, 96 insertions(+), 70 deletions(-)
Signature · 1 line
2.9.3