tty: drop broken alt-speed handling
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | serial: rate limit custom-speed deprecation noticedrivers/ | +2 | 0 replies | |
| 2/9 | USB: serial: ftdi_sio: simplify TIOCSSERIAL flag logicdrivers/ | +5 | 0 replies | |
| 3/9 | USB: serial: ftdi_sio: remove broken alt-speed handlingdrivers/ | +9 | 0 replies | |
| 4/9 | tty: simserial: drop unused alt_speed handlingarch/ | +0 | 0 replies | |
| 5/9 | tty: amiserial: drop broken alt-speed supportdrivers/ | +3 | 0 replies | |
| 6/9 | tty: cyclades: drop broken alt-speed supportdrivers/ | +9 | 0 replies | |
| 7/9 | tty: rocket: drop broken alt-speed supportdrivers/ | +6 | 0 replies | |
| 8/9 | tty: ircomm: remove dead and broken ioctl codenet/ | +1 | 5 replies | |
| 9/9 | tty: drop unused alt_speed from tty_structinclude/ | +0 | 0 replies |
Reviews trailers per patch
None of the 9 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Alan Cox | Andy Shevchenko |
|---|---|---|
| Series | R-b | R-b |
| 1/9 | ||
| 2/9 | ||
| 3/9 | ||
| 4/9 | ||
| 5/9 | ||
| 6/9 | ||
| 7/9 | ||
| 8/9 | ||
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/9] tty: drop broken alt-speed handling
Setting an alt-speed using TIOCSSERIAL and SPD flags has been deprecated since v2.1.69 and has been broken for all tty drivers but serial-core since v3.10 and commit 6865ff222cca ("TTY: do not warn about setting speed via SPD_*") without anyone noticing (for four years).
Instead of reverting the offending commit, lets get rid of this legacy code while adding back a warning about the SPD flags being deprecated to the drivers that once implemented it. Note that drivers implementing SPD_CUST will continue to support using a custom divisor.
Also note that serial-core did not rely on the TTY layer for SPD handling and continues to support it while warning about deprecation (since 2003 at least).
Greg, I suggest you take it all trough the TTY tree even if merging through multiple trees and applying the final patch once everything is upstream would be an option. Also the irda clean up does not depend on the rest of series as the code implementing SPD handling was ifdefed out.
Johan
Johan Hovold (9):
serial: rate limit custom-speed deprecation notice
USB: serial: ftdi_sio: simplify TIOCSSERIAL flag logic
USB: serial: ftdi_sio: remove broken alt-speed handling
tty: simserial: drop unused alt_speed handling
tty: amiserial: drop broken alt-speed support
tty: cyclades: drop broken alt-speed support
tty: rocket: drop broken alt-speed support
tty: ircomm: remove dead and broken ioctl code
tty: drop unused alt_speed from tty_struct
arch/ia64/hp/sim/simserial.c | 13 ----- drivers/tty/amiserial.c | 23 ++------ drivers/tty/cyclades.c | 21 ++++---- drivers/tty/rocket.c | 27 +++------- drivers/tty/serial/serial_core.c | 5 +- drivers/usb/serial/ftdi_sio.c | 67 +++++------------------ include/linux/tty.h | 1 - net/irda/ircomm/ircomm_tty_ioctl.c | 107 +------------------------------------ 8 files changed, 34 insertions(+), 230 deletions(-)
Signature · 1 line
2.13.0