Skip to content

Refactor RDMA netlink infrastructure

Leon Romanovsky linux-rdma 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 4 repliesIn review
  2. v25 patches 5 repliesSuperseded
  3. v15 patches 6 repliesSuperseded

Changes in v3 from the cover letter

* Rebase on top -rc4.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5RDMA/netlink: Remove netlink clients infrastructuredrivers/infiniband/core/cma.c drivers/infiniband/core/core_priv.h drivers/infiniband/core/device.c +3 more+110 -1493 replies
2/5RDMA/netlink: Remove redundant owner option for netlink callbacksdrivers/infiniband/core/cma.c drivers/infiniband/core/netlink.c include/rdma/rdma_netlink.h+1 -51 reply
3/5RDMA/netlink: Avoid double pass for RDMA netlink messagesdrivers/infiniband/core/netlink.c+44 -180 replies
4/5RDMA/iwcm: Remove useless check of nelink client validitydrivers/infiniband/core/iwpm_util.c+0 -60 replies
5/5RDMA/iwcm: Remove extra EXPORT_SYMBOLSdrivers/infiniband/core/iwpm_msg.c drivers/infiniband/core/iwpm_util.c+0 -170 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchChien Tin Tung
1/5R-b
2/5
3/5
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH rdma-next V3 0/5] Refactor RDMA netlink infrastructure

The following patch set is a preparation to addition of netlink handlers to support RDMA tool. It simplifies the code, removes useless client infrastructure, concentrates netlink validity checks and allows future patches to remove a lot of dead code from iwcm* code base (all operations related to nl_clients).

It is based on already sent to the mailing list patch [1] "Revert "IB/core: Add flow control to the portmapper netlink calls""

[1] https://patchwork.kernel.org/patch/9752865/

Changelog
v2->v3:
* Rebase on top -rc4.
v1->v2:
* Added Chien's ROB tags
Patch #1:
* Annotate max_num_ops with "static const" to calculate the value once only.

v0->v1:
* Moved to separate topic from rdmatool.
Patch #1:
* Add check to catch already initialized callback table to avoid double registration of the same protocol.
* Rewrite the validity check to use array instead of switch().

CC Bart Van Assche <[email protected]>
CC Chien Tin Tung <[email protected]>
CC Steve Wise <[email protected]>

Available in the "topic/betlink-refactor-v3" topic branch of this git repo:
git://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git

Or for browsing:
https://git.kernel.org/cgit/linux/kernel/git/leon/linux-rdma.git/log/?h=topic/netlink-refactor-v3

Leon Romanovsky (5):
RDMA/netlink: Remove netlink clients infrastructure RDMA/netlink: Remove redundant owner option for netlink callbacks RDMA/netlink: Avoid double pass for RDMA netlink messages RDMA/iwcm: Remove useless check of nelink client validity RDMA/iwcm: Remove extra EXPORT_SYMBOLS

 drivers/infiniband/core/cma.c       |   9 +-
 drivers/infiniband/core/core_priv.h |   4 +-
 drivers/infiniband/core/device.c    |  41 ++----
 drivers/infiniband/core/iwcm.c      |  10 +-
 drivers/infiniband/core/iwpm_msg.c  |  12 --
 drivers/infiniband/core/iwpm_util.c |  11 --
 drivers/infiniband/core/netlink.c   | 249 +++++++++++++++++++-----------------
 include/rdma/rdma_netlink.h         |  14 +-
 8 files changed, 155 insertions(+), 195 deletions(-)

--
2.13.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html