Skip to content

target/s390x: implement MVCOS and allow to enable it

David Hildenbrand qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v13 patches 12 repliesSuperseded

Changes in v2 from the cover letter

- Squashed CPU model change and don't fake abscence
- Introduced a memhelper to do bulk access
- Minor style and bug fixes suggested/found by Thomas + Richard
- CR0_SECONDARY define was wrong :(
- introduce defines for AC_*
- enable the instruction for USER MODE (however will always result in a PRIVILEDGED exception)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2target/s390x: change PSW_SHIFT_KEYtarget/s390x/cpu.h target/s390x/translate.c+2 -20 replies
2/2target/s390x: implement mvcos instructiontarget/s390x/cpu.h target/s390x/cpu_models.c target/s390x/helper.h +3 more+199 -162 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchThomas Huth
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/2] target/s390x: implement MVCOS and allow to enable it

This will not change the qemu model, we simply allow to enable the facility for the qemu model.

A current upstream kernel (compiled for e.g. z900) can be tricked into using MVCOS for uaccess by simply enabling the facility. This will work even though the kernel is not compiled with z10+ support, as this facility is also detected and used dynamically.

qemu-system-s390x ... -cpu qemu,mvcos=on ...

Requires my PGM fix series:
https://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg02631.html

Based on an original patch by Miroslav Benes

v1 -> v2:
- Squashed CPU model change and don't fake abscence
- Introduced a memhelper to do bulk access
- Minor style and bug fixes suggested/found by Thomas + Richard
- CR0_SECONDARY define was wrong :(
- introduce defines for AC_*
- enable the instruction for USER MODE (however will always result in a PRIVILEDGED exception)

David Hildenbrand (2):
target/s390x: change PSW_SHIFT_KEY
target/s390x: implement mvcos instruction

 target/s390x/cpu.h         |  24 +++++-
 target/s390x/cpu_models.c  |   1 +
 target/s390x/helper.h      |   1 +
 target/s390x/insn-data.def |   2 +
 target/s390x/mem_helper.c  | 180 +++++++++++++++++++++++++++++++++++++++++----
 target/s390x/translate.c   |  11 ++-
 6 files changed, 201 insertions(+), 18 deletions(-)
Signature · 1 line
2.9.3

Read the cover letter in its thread