Skip to content

DT printf format specifiers

Rob Herring linux-devicetree lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4of: use kbasename instead of open codingdrivers/of/base.c drivers/of/platform.c drivers/of/resolver.c+4 -71 reply
2/4of: find_node_by_full_name rewrite to compare each leveldrivers/of/base.c drivers/of/of_private.h drivers/of/resolver.c+25 -370 replies
3/4of: Custom printk format specifier for device nodeDocumentation/printk-formats.txt lib/vsprintf.c scripts/checkpatch.pl+166 -212 replies
4/4of: Convert to using %pOF instead of full_namedrivers/of/address.c drivers/of/base.c drivers/of/device.c +7 more+136 -1301 reply

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchAndy ShevchenkoJoe Perches
1/4R-b
2/4
3/4A-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] DT printf format specifiers

This resurrects an old patch[1] from Pantelis adding printf format specifiers for DT nodes. The previous versions didn't get applied after debate about the what character(s) to use. Grant suggested %pO for base kobject and %pOF for struct device_node. Everyone agreed, but no new version was posted.

I ended up re-writing the core implementation to be more inline with how other format specifiers are written which allowed removing #define code fragments. The other 3 patches convert the core DT code to use %pOF and prepare for changing device_node.full_name to stop storing the full path for every node.

My plan is to merge this series for v4.13 and post follow-up patches to convert all arches and subsystems to %pOF for v4.14. The full series is available here[2]. I tested this on QEMU running the DT unittests.

Rob

[1] https://patchwork.kernel.org/patch/6127521/
[2] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git dt-printf

Pantelis Antoniou (1):
of: Custom printk format specifier for device node

Rob Herring (3):
of: use kbasename instead of open coding
of: find_node_by_full_name rewrite to compare each level
of: Convert to using %pOF instead of full_name

 Documentation/printk-formats.txt |  31 +++++++++
 drivers/of/address.c             |  21 +++---
 drivers/of/base.c                |  76 ++++++++++++----------
 drivers/of/device.c              |   2 +-
 drivers/of/dynamic.c             |  33 +++++-----
 drivers/of/irq.c                 |  10 +--
 drivers/of/of_mdio.c             |  10 +--
 drivers/of/of_pci.c              |  29 ++++-----
 drivers/of/of_private.h          |   3 +
 drivers/of/overlay.c             |  21 +++---
 drivers/of/platform.c            |  34 +++++-----
 drivers/of/resolver.c            |  34 ++--------
 drivers/of/unittest.c            |  66 +++++++++++--------
 lib/vsprintf.c                   | 135 ++++++++++++++++++++++++++++++++++++++-
 scripts/checkpatch.pl            |   2 +-
 15 files changed, 331 insertions(+), 176 deletions(-)
Signature · 6 lines
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html