core: check hashes of license files
Get series with b4
b4 am 20170619174707.GB3045@scaerVersions newest first
- v1 Latest0 of 3 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 3 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Buildroot] [PATCH 0/3] core: check hashes of license files
Rahul, All,
On 2017-06-19 22:47 +0530, Rahul Bedarkar spake thusly:
Quoted 12 lines · Yann E. MORIN
Quoted 6 lines
Hello All!
This small series is a proposal to check the hashes of the license files during legal-info, to catch the packages whose license changes but where the text of the new license is in the same file.
Thanks for this series. Checking hashes of the license files during legal-info stage looks logical but we discussed about doing that after downloading sources so that change in license file is noticed early (as a part of build test after version bump).
It is not possible to do at download time. It can only be done after the package has been extracted and patched.
That is why, when you run legal-info on a non-built (but configured) tree, you'll notice that Buildroot extracts and patches the packages before saving their legal-info.
Besides, if one uses the support/scripts/test-pkg script to test the version bump, then legal-info is run by the script.
So, I still believe it is better done during legal-info.
Regards,
Yann E. MORIN.
Quoted 45 lines
Regards,
RahulQuoted 42 lines
This was suggested by Rahul recently:
http://lists.busybox.net/pipermail/buildroot/2017-June/194425.htmlRegards,
Yann E. MORIN.The following changes since commit
859764ac39c18c6aaabbb6a1a47f2fa2e5793044linux-headers: bump 4.{1, 4, 9, 11}.x series (2017-06-17 16:17:04 +0200)
are available in the git repository at:
git://git.buildroot.org/~ymorin/git/buildroot.gitfor you to fetch changes up to
41013c99543173da1ec547219c7f67e52d323a40docs/manual: document hashes for license files (2017-06-18 09:59:06 +0200)
----------------------------------------------------------------
Yann E. MORIN (3):
core/pkg-util: pass package directory and name when saving license files core/pkg-utils: check hashes of license files
docs/manual: document hashes for license filesMakefile | 2 +- docs/manual/adding-packages-directory.txt | 16 ++++++++++++++-- package/pkg-generic.mk | 2 +- package/pkg-utils.mk | 11 ++++++++--- 4 files changed, 24 insertions(+), 7 deletions(-)--
.-----------------.--------------------.------------------.--------------------.| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |'------------------------------^-------^------------------^--------------------'
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'