grep: remove redundant code & reflags from API
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 1 replyIn review
- v15 patches 5 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | grep: remove redundant double assignment to 0grep.c | +0 | 0 replies | |
| 2/6 | grep: adjust a redundant grep pattern type assignmentgrep.c | +1 | 0 replies | |
| 3/6 | grep: remove redundant "fixed" field re-assignment to 0grep.c | +0 | 0 replies | |
| 4/6 | grep: remove redundant and verbose re-assignments to 0grep.c | +0 | 0 replies | |
| 5/6 | grep: remove regflags from the public grep_opt APIbuiltin/ grep.c grep.h +1 more | +34 | 1 reply | |
| 6/6 | grep: remove redundant REG_NEWLINE when compiling fixed regexgrep.c | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/6] grep: remove redundant code & reflags from API
Addresses comments from Stefan Beller (thanks!). I looked into it and the REG_NEWLINE flag was redundant in 1/2 cases, see 6/6 for the removal of that.
I looked into refactoring 5/6 as noted in [email protected], but for the reasons now explained in the last paragraph of 5/6 decided not to and to keep it as it was.
Ævar Arnfjörð Bjarmason (6):
grep: remove redundant double assignment to 0
grep: adjust a redundant grep pattern type assignment
grep: remove redundant "fixed" field re-assignment to 0
grep: remove redundant and verbose re-assignments to 0
grep: remove regflags from the public grep_opt API
grep: remove redundant REG_NEWLINE when compiling fixed regex
builtin/grep.c | 2 -- grep.c | 62 +++++++++++++++++++++++++++++++++------------------------- grep.h | 1 - revision.c | 2 -- 4 files changed, 35 insertions(+), 32 deletions(-)
Signature · 1 line
2.13.1.611.g7e3b11ae1