Skip to content

ntlm: remove warnings and improve code style

Antonio Quartulli openvpn-devel 1 version In review

Get series with b4
b4 am [email protected]...

Versions newest first

  1. v1 Latest4 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ntlm: convert binary buffers to uint8_t *src/openvpn/ntlm.c+27 -242 replies
2/4ntlm: avoid useless castsrc/openvpn/ntlm.c+2 -23 replies
3/4ntlm: restyle compressed multiple function callssrc/openvpn/ntlm.c+2 -22 replies
4/4ntlm: improve code style and readabilitysrc/openvpn/ntlm.c+45 -292 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Openvpn-devel] [PATCH 0/4] ntlm: remove warnings and improve code style

This small patcheset is aimed to simply remove some unnecessary warnings and improve the readability of ntlm.c.

Compile tests have been performed with "-Wall -std=c99".

This is another step towards having a clean build when using -Wall.

Cheers,

Antonio Quartulli (4):
ntlm: convert binary buffers to uint8_t *
ntlm: avoid useless cast
ntlm: restyle compressed multiple function calls
ntlm: improve code style and readability

 src/openvpn/ntlm.c | 129 ++++++++++++++++++++++++++++++-----------------------
 1 file changed, 74 insertions(+), 55 deletions(-)
Signature · 1 line
2.13.2