Skip to content

firmware: few more fixes - fix batched requests

Luis R. Rodriguez linux-fsdevel lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4firmware: define pr_fmtdrivers/base/firmware_class.c+2 -00 replies
2/4firwmare: enable a debug print for batched requestsdrivers/base/firmware_class.c+2 -01 reply
3/4test_firmware: add batched firmware testslib/test_firmware.c tools/testing/selftests/firmware/fw_filesystem.sh+697 -20 replies
4/4firmware: fix batched requests: send wake up on failure on direct lookupsdrivers/base/firmware_class.c+30 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] firmware: few more fixes - fix batched requests

Greg,

As I hinted as I worked on the last firmware fixes, the batched requests mechanism of the firmware API still had one remaining issue which has been broken for a long time. This series fixes the last issue I am aware of.

I've written test cases for it using a smiller test interface which we can later port the other tests for it. I haven't moved the old tests to it given a) kselftests are being tested on older kernels with older test_firmware drivers so moving the tests would nullify the old tests. We could later address this by checking for both triggers for compatibility purposes but we would also have to test for everything we tested for the old tests. The new tests only first prioritize batched requets for now. With time we could mesh them all together and still remain compatible with the old test_firmware on older kernels.

I've pushed testsing on all kernel configuration possible and provide report of the issue on all configurations as well, before and after for all the APIs.

This series depends on the last series of fixes I had posted before. As usual I have a tree with this and all other pending fixes on my linux-next tree on the 20170714-fw-fix-batched-req branch [0] based on linux-next tag next-20170714.

If there any questions please let me know.

[0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20170714-fw-fix-batched-req

Luis R. Rodriguez (4):
firmware: define pr_fmt
firwmare: enable a debug print for batched requests
test_firmware: add batched firmware tests
firmware: fix batched requests: send wake up on failure on direct
lookups

 drivers/base/firmware_class.c                     |  42 +-
 lib/test_firmware.c                               | 594 ++++++++++++++++++++++
 tools/testing/selftests/firmware/fw_filesystem.sh | 105 +++-
 3 files changed, 731 insertions(+), 10 deletions(-)
Signature · 1 line
2.11.0