Skip to content

Update: Week 10

Prathamesh Chavan git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 4 repliesIn review
  2. v113 patches 9 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13submodule--helper: introduce get_submodule_displaypath()builtin/submodule--helper.c+22 -110 replies
2/13submodule--helper: introduce for_each_submodule_list()builtin/submodule--helper.c+29 -100 replies
3/13submodule: port set_name_rev() from shell to Cbuiltin/submodule--helper.c git-submodule.sh+66 -140 replies
4/13submodule: port submodule subcommand 'status' from shell to Cbuiltin/submodule--helper.c git-submodule.sh+158 -481 reply
5/13submodule: port submodule subcommand 'sync' from shell to Cbuiltin/submodule--helper.c git-submodule.sh+183 -550 replies
6/13submodule: port submodule subcommand 'deinit' from shell to Cbuiltin/submodule--helper.c git-submodule.sh+145 -540 replies
7/13diff: change scope of the function count_lines()diff.c diff.h+2 -10 replies
8/13submodule: port submodule subcommand 'summary' from shell to Cbuiltin/submodule--helper.c git-submodule.sh+434 -1812 replies
9/13submodule foreach: correct '$path' in nested submodules from a subdirectorygit-submodule.sh t/t7407-submodule-foreach.sh+34 -30 replies
10/13submodule foreach: document '$sm_path' instead of '$path'Documentation/git-submodule.txt+6 -40 replies
11/13submodule foreach: clarify the '$toplevel' variable documentationDocumentation/git-submodule.txt+2 -10 replies
12/13submodule foreach: document variable '$displaypath'Documentation/git-submodule.txt t/t7407-submodule-foreach.sh+15 -130 replies
13/13submodule: port submodule subcommand 'foreach' from shell to Cbuiltin/submodule--helper.c git-submodule.sh+137 -380 replies

Reviews trailers per patch

None of the 13 patches has a Reviewed-by or Acked-by.

PatchChristian CouderStefan BellerBrandon Williams
1/13Mentored-by Mentored-by
2/13Mentored-by Mentored-by
3/13Mentored-by Mentored-by
4/13Mentored-by Mentored-by
5/13Mentored-by Mentored-by
6/13Mentored-by Mentored-by
7/13Mentored-by Mentored-by
8/13Mentored-by Mentored-by
9/13
10/13
11/13
12/13
13/13Mentored-by Mentored-by Helped-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [GSoC][PATCH v2 00/13] Update: Week 10

Thank you Brandon Williams <[email protected]> for reviewing the previous patch series.
Also, I'm sorry for repling late to your reviews. The main reason was to give sufficient time to prepare the next version of each patch as suggested.
The changes made in each patch are enlisted in the patch itself.

Complete build report of this work is available at: [1]
Branch: week-10
Build #142

Also, I have push the work on github as well and can be checked out at: [2]

[1]: https://travis-ci.org/pratham-pc/git/builds
[2]: https://github.com/pratham-pc/git/commits/week-10

Prathamesh Chavan (13):
submodule--helper: introduce get_submodule_displaypath()
submodule--helper: introduce for_each_submodule_list()
submodule: port set_name_rev() from shell to C
submodule: port submodule subcommand 'status' from shell to C
submodule: port submodule subcommand 'sync' from shell to C
submodule: port submodule subcommand 'deinit' from shell to C
diff: change scope of the function count_lines()
submodule: port submodule subcommand 'summary' from shell to C submodule foreach: correct '$path' in nested submodules from a
subdirectory
submodule foreach: document '$sm_path' instead of '$path' submodule foreach: clarify the '$toplevel' variable documentation submodule foreach: document variable '$displaypath'
submodule: port submodule subcommand 'foreach' from shell to C

 Documentation/git-submodule.txt |   15 +-
 builtin/submodule--helper.c     | 1186 ++++++++++++++++++++++++++++++++++++++-
 diff.c                          |    2 +-
 diff.h                          |    1 +
 git-submodule.sh                |  394 +------------
 t/t7407-submodule-foreach.sh    |   38 +-
 6 files changed, 1218 insertions(+), 418 deletions(-)
Signature · 1 line
2.13.0