Skip to content

Incremental rewrite of git-submodules

Prathamesh Chavan git 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest3 patches 4 repliesIn review
  2. v63 patches 4 repliesSuperseded
  3. v54 patches 5 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v44 patches0 repliesSuperseded
v34 patches4 repliesSuperseded
v24 patches7 repliesSuperseded
v113 patches1 replySuperseded

Changes in v7 from the cover letter

* Instead of using cb_flags in the callback data's struct, 'flags' is used.

* Similar changes were applied to the CB_OPT_QUIET and other bits.

* The function compute_rev_name() was formatted in accordance with the "make style", into a compact version.

* Call to precompose_argv() in the function status_submodule() was dropped as the call was unnecessary.

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3submodule--helper: introduce get_submodule_displaypath()builtin/submodule--helper.c+23 -121 reply
2/3submodule--helper: introduce for_each_listed_submodule()builtin/submodule--helper.c+35 -51 reply
3/3submodule: port submodule subcommand 'status' from shell to Cbuiltin/submodule--helper.c git-submodule.sh+199 -600 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchChristian CouderStefan Beller
1/3Mentored-by Mentored-by
2/3Mentored-by Mentored-by
3/3Mentored-by Mentored-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/3] Incremental rewrite of git-submodules

Changes in v7:

* Instead of using cb_flags in the callback data's struct, 'flags' is used.

* Similar changes were applied to the CB_OPT_QUIET and other bits.

* The function compute_rev_name() was formatted in accordance with the "make style", into a compact version.

* Call to precompose_argv() in the function status_submodule() was dropped as the call was unnecessary.

As before you can find this series at:
https://github.com/pratham-pc/git/commits/patch-series-1

And its build report is available at:
https://travis-ci.org/pratham-pc/git/builds/
Branch: patch-series-1
Build #190

The above changes were based on master branch.

Another branch, similar to the above, was created, but was based on the 'next' branch.
Complete build report of that is also available at:
https://travis-ci.org/pratham-pc/git/builds
Branch: patch-series-1-next
Build #189
The above changes are also push on github and are available at:
https://github.com/pratham-pc/git/commits/patch-series-1-next

Prathamesh Chavan (3):
submodule--helper: introduce get_submodule_displaypath()
submodule--helper: introduce for_each_listed_submodule()
submodule: port submodule subcommand 'status' from shell to C

 builtin/submodule--helper.c | 273 +++++++++++++++++++++++++++++++++++++++++---
 git-submodule.sh            |  61 +---------
 2 files changed, 257 insertions(+), 77 deletions(-)
Signature · 1 line
2.14.2