Skip to content

fpga: add attribute groups

Alan Tull linux-fpga lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2fpga: add attribute groupsdrivers/fpga/fpga-bridge.c drivers/fpga/fpga-mgr.c drivers/fpga/fpga-region.c +3 more+9 -00 replies
2/2fpga: altera-cvp: register attribute groups using opsdrivers/fpga/altera-cvp.c+19 -202 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] fpga: add attribute groups

Make it easy to add device attribute groups when registering an FPGA manager, bridge, or region. This way, the sysfs attributes are added in device_add instead of afterwards which can lead to race conditions [1].

Patch 1: add groups to the structs that are used when a manager, bridge, or region is registered.

Patch 2: changes to altera cvp FPGA manager to use this method of registering.

I've tested this method on platform devices. Patch 2 builds but is untested.

This patchset is dependent on my "non-dt support" patchset currently under review.

[1] http://www.kroah.com/log/blog/2013/06/26/how-to-create-a-sysfs-file-correctly/

Alan Tull (2):
fpga: add attribute groups
fpga: altera-cvp: register attribute groups using ops

 drivers/fpga/altera-cvp.c        | 39 +++++++++++++++++++--------------------
 drivers/fpga/fpga-bridge.c       |  1 +
 drivers/fpga/fpga-mgr.c          |  1 +
 drivers/fpga/fpga-region.c       |  1 +
 include/linux/fpga/fpga-bridge.h |  2 ++
 include/linux/fpga/fpga-mgr.h    |  2 ++
 include/linux/fpga/fpga-region.h |  2 ++
 7 files changed, 28 insertions(+), 20 deletions(-)
Signature · 1 line
2.7.4