Skip to content

Several hwmon fixes

Karol Herbst nouveau 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3therm: split return code and value in nvkm_get_tempdrm/nouveau/include/nvkm/subdev/therm.h drm/nouveau/nouveau_hwmon.c drm/nouveau/nvkm/subdev/therm/base.c +5 more+50 -350 replies
2/3hwmon: properly check for errorsdrm/nouveau/nouveau_hwmon.c+26 -70 replies
3/3subdev/volt/gk104: return error when read failsdrm/nouveau/nvkm/subdev/volt/gk104.c+6 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Several hwmon fixes

We should simply return errors while the GPU is turned off, because the sensors aren't accessable and setting any kind of value doesn't make any sense. Fixes sensors values reported by "sensors"

Before:
nouveau-pci-0100

Adapter: PCI adapter
GPU core:     +0.60 V  (min =  +0.60 V, max =  +1.20 V)
temp1:         -0.0°C  (high = +95.0°C, hyst =  +3.0°C)
                       (crit = +105.0°C, hyst =  +5.0°C)
                       (emerg = +135.0°C, hyst =  +5.0°C)

power1: -22.00 uW

After:
nouveau-pci-0100

Adapter: PCI adapter
GPU core:         N/A  (min =  +0.60 V, max =  +1.20 V)
temp1:            N/A  (high = +95.0°C, hyst =  +3.0°C)
                       (crit = +105.0°C, hyst =  +5.0°C)
                       (emerg = +135.0°C, hyst =  +5.0°C)

power1: N/A

Karol Herbst (3):
therm: split return code and value in nvkm_get_temp
hwmon: properly check for errors subdev/volt/gk104: return error when read fails

 drm/nouveau/include/nvkm/subdev/therm.h |  2 +-
 drm/nouveau/nouveau_hwmon.c             | 48 ++++++++++++++++++++++++---------
 drm/nouveau/nvkm/subdev/therm/base.c    | 19 +++++++++----
 drm/nouveau/nvkm/subdev/therm/g84.c     | 11 ++++----
 drm/nouveau/nvkm/subdev/therm/nv40.c    |  9 +++----
 drm/nouveau/nvkm/subdev/therm/nv50.c    |  9 +++----
 drm/nouveau/nvkm/subdev/therm/priv.h    |  4 +--
 drm/nouveau/nvkm/subdev/therm/temp.c    | 16 ++++++++---
 drm/nouveau/nvkm/subdev/volt/gk104.c    |  7 ++++-
 9 files changed, 82 insertions(+), 43 deletions(-)
Signature · 6 lines
2.14.1

_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau