Skip to content

iotests: cure s390x failures by switching to ccw/aliases

Cornelia Huck qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 7 repliesIn review
  2. v13 patches 16 repliesSuperseded

Changes in v2 from the cover letter

- avoid adding new reference output by adding post-processing to 051 and switching to aliases for 067

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3iotests: use -ccw on s390x for 040, 139, and 182tests/qemu-iotests/040 tests/qemu-iotests/139 tests/qemu-iotests/182+26 -51 reply
2/3iotests: use -ccw on s390x for 051tests/qemu-iotests/051 tests/qemu-iotests/051.out tests/qemu-iotests/051.pc.out+13 -32 replies
3/3iotests: use virtio aliases for 067tests/qemu-iotests/067 tests/qemu-iotests/067.out+3 -22 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKevin WolfThomas HuthDavid HildenbrandQingFeng Hao
SeriesR-b
1/3R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/3] iotests: cure s390x failures by switching to ccw/aliases

Recent changes in s390x made pci support dependant on the zpci cpu feature, which is not provided on all models (and not on by default). This means we cannot instatiate pci devices on a standard qemu invocation for s390x. Moreover, the zpci instructions are not even wired up for tcg yet, so actually doing anything with those pci devices is bound to fail on tcg.

For 040, 051, 139, and 182, this can be fixed by switching to virtio-ccw from virtio-pci on s390x. 051 also needs a bit of post-processing on the output.

For 067, it is easier to switch to virtio aliases, which will pick virtio-ccw on s390x and virtio-pci elsewhere. It also exercises the aliasing path.

v1->v2:
- avoid adding new reference output by adding post-processing to 051 and switching to aliases for 067

Cornelia Huck (3):
iotests: use -ccw on s390x for 040, 139, and 182
iotests: use -ccw on s390x for 051
iotests: use virtio aliases for 067

 tests/qemu-iotests/040        |  6 +++++-
 tests/qemu-iotests/051        | 12 +++++++++++-
 tests/qemu-iotests/051.out    |  2 +-
 tests/qemu-iotests/051.pc.out |  2 +-
 tests/qemu-iotests/067        |  3 ++-
 tests/qemu-iotests/067.out    |  2 +-
 tests/qemu-iotests/139        | 12 ++++++++++--
 tests/qemu-iotests/182        | 13 +++++++++++--
 8 files changed, 42 insertions(+), 10 deletions(-)
Signature · 1 line
2.13.5