Skip to content

Improve websock response / error handling

Daniel P. Berrange qemu-devel 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 0 repliesNew
  2. v33 patches 2 repliesSuperseded
  3. v23 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches3 repliesSuperseded

Changes in v4 from the cover letter

- Use time() instead of gettimeofday() to avoid data type cast problems on mingw

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3io: send proper HTTP response for websocket errorsio/channel-websock.c+139 -460 replies
2/3io: include full error message in websocket handshake traceio/channel-websock.c io/trace-events+5 -40 replies
3/3io: use case insensitive check for Connection & Upgrade websock headersio/channel-websock.c+2 -20 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchEric BlakePhilippe Mathieu-Daudé
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Qemu-devel] [PATCH v4 0/3] Improve websock response / error handling

A followup of:

v1: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01176.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01974.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02108.html

Changed in v4:

- Use time() instead of gettimeofday() to avoid data type cast problems on mingw

Changed in v3:

- Use strftime instead of g_date_time_format

Changed in v2:

- Drop redundant return statement
- Drop redundant variable initialization
- Assert that g_date_time_format is non-NULL

Daniel P. Berrange (3):
io: send proper HTTP response for websocket errors
io: include full error message in websocket handshake trace
io: use case insensitive check for Connection & Upgrade websock
headers

 io/channel-websock.c | 194 ++++++++++++++++++++++++++++++++++++++-------------
 io/trace-events      |   2 +-
 2 files changed, 145 insertions(+), 51 deletions(-)
Signature · 1 line
2.13.5