phy: rockchip-typec: Set "flip" properly; some cleanups; fix swing
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 1 replyIn review
- v24 patches 2 repliesSuperseded
- v13 patches 1 replySuperseded
Changes in v3 from the cover letter
- Voltage swing patch now patch 2.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | phy: rockchip-typec: Set the AUX channel flip state earlierdrivers/ | +42 | 0 replies | |
| 2/4 | phy: rockchip-typec: Don't set the aux voltage swing to 400 mVdrivers/ | +4 | 0 replies | |
| 3/4 | phy: rockchip-typec: Avoid magic numbers + add delays in aux calibdrivers/ | +163 | 0 replies | |
| 4/4 | phy: rockchip-typec: Do the calibration more correctlydrivers/ | +18 | 1 reply |
Reviews trailers per patch
3 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Chris Zhong |
|---|---|
| 1/4 | R-b |
| 2/4 | |
| 3/4 | R-b |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/4] phy: rockchip-typec: Set "flip" properly; some cleanups; fix swing
When connecting to certain DP monitors it was observed that only one of the two orientations of the type C to DP cable would work. Debugging showed that the problem was that we needed to set the type C "flip" state earlier. Once we did this, problems went away.
While trying to dig into this problem and some others, I found that the proper documentation for the Type C PHY was available to me. This allowed me to cleanup the magic numbers in the funtion that I was touching and also fix a few minor issues that (luckily) haven't caused any problems yet.
I also found that aux channel communications were flaky on some adapters until I adjusted the voltage swing.
For this series I've added Chris Zhong's Reviewed-by tags to some of the patches since he gave a +1 to nearly identical patches on the Chrome OS gerrit and I didn't think he'd mind me carrying his tag. If folks would rather I didn't do that, please yell.
Changes in v3:
- Voltage swing patch now patch 2.
Changes in v2:
- Voltage swing patch new for v2.
- Removed extra blank line.
Douglas Anderson (4):
phy: rockchip-typec: Set the AUX channel flip state earlier
phy: rockchip-typec: Don't set the aux voltage swing to 400 mV
phy: rockchip-typec: Avoid magic numbers + add delays in aux calib
phy: rockchip-typec: Do the calibration more correctly
drivers/phy/rockchip/phy-rockchip-typec.c | 246 ++++++++++++++++++++++++------ 1 file changed, 201 insertions(+), 45 deletions(-)
Signature · 1 line
2.14.1.821.g8fa685d3b7-goog