hmp: fix "dump-quest-memory" segfault
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest4 patches 6 repliesIn review
- v33 patches 19 repliesApplied
- v23 patches 12 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 1 patch | 15 replies | Superseded |
Changes in v4 from the cover letter
- update comment in test-hmp.c
- add cohuck's patch
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | hmp: fix "dump-quest-memory" segfault (ppc)target/ | +9 | 1 reply | |
| 2/4 | hmp: fix "dump-quest-memory" segfault (arm)target/ | +9 | 1 reply | |
| 3/4 | dump: do not dump non-existent guest memorydump.c | +6 | 3 replies | |
| 4/4 | tests/hmp: test "none" machine with memorytests/ | +4 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Greg Kurz | Thomas Huth | Laurent Vivier | Peter Xu | Cornelia Huck | David Gibson | Eric Auger |
|---|---|---|---|---|---|---|---|
| 1/4 | R-b | R-b | A-b | ||||
| 2/4 | R-b | R-b | R-b T-b | ||||
| 3/4 | R-b | T-b R-b | R-b | ||||
| 4/4 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.
Cover letter [Qemu-arm] [PATCH v4 0/4] hmp: fix "dump-quest-memory" segfault
Fix aarch64 and ppc when dump-guest-memory is used with none machine type and no CPU.
The other machine types don't have the problem.
Update test-hmp, to test none machine type with (2 MB) and without memory, and add a test to test dump-quest-memory without filter parameters
v4:
- update comment in test-hmp.c
- add cohuck's patch
v3:
- remove blank line after a comment
- forbid memory dump when there is no CPU
v2:
- add arm fix
- update test-hmp
Cornelia Huck (1):
dump: do not dump non-existent guest memory
Laurent Vivier (3):
hmp: fix "dump-quest-memory" segfault (ppc)
hmp: fix "dump-quest-memory" segfault (arm) tests/hmp: test "none" machine with memory
dump.c | 6 ++++++ target/arm/arch_dump.c | 11 +++++++++-- target/ppc/arch_dump.c | 11 +++++++++-- tests/test-hmp.c | 4 ++++ 4 files changed, 28 insertions(+), 4 deletions(-)
Signature · 1 line
2.13.5