Skip to content

Initial write support for MTP objects

Bandan Das qemu-devel 6 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest5 patches 0 repliesNew
  2. v55 patches 0 repliesSuperseded
  3. v45 patches 6 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v35 patches0 repliesSuperseded
v25 patches5 repliesSuperseded
v15 patches0 repliesSuperseded

Changes in v6 from the cover letter

4/5,5/5: Cleanup some checkpatch errors. Thank you, Patchew!

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5usb-mtp: Add one more argument when building resultshw/usb/dev-mtp.c+27 -230 replies
2/5usb-mtp: print parent path in IN_IGNORED trace fnhw/usb/dev-mtp.c+2 -30 replies
3/5usb-mtp: Support delete of mtp objectshw/usb/dev-mtp.c+123 -00 replies
4/5usb-mtp: Introduce write support for MTP objectshw/usb/dev-mtp.c+155 -20 replies
5/5usb-mtp: Advertise SendObjectInfo for write supporthw/usb/dev-mtp.c+134 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [Qemu-devel] [PATCH v6 0/5] Initial write support for MTP objects

v6:
4/5,5/5: Cleanup some checkpatch errors. Thank you, Patchew!

v5:
4/5,5/5: Add check for the RO bit and set response to STORE_READ_ONLY

v4:
4/5: Remove getumask and set default permissions to 0644 5/5: Remove usb_mtp_object_lookup_name out of #ifdef CONFIG_INOTIFY1 Test compilation on freebsd

v3:
3/5: Add a property that sets r/w to on/off (default:off)
Restructure ifdefs
4/5: Sort the response codes
5/5: Use actual names for fields in the dataset
Copy uint16_t to wchar_t and use wcstombs to get char type for filename
v2:
3/5: Set mtp store flag to read only
4/5: Fix compiler warnings and change default file permissions 5/5: Fix file permissions

These patches implement write support for Qemu's MTP emulation. Simple tests such as delete/move/edit/copy work ok. Current issues/TODO:

- File transfers > 4GB has not been tested and will probably not work
- Some (or most) MTP clients don't advertise hidden files and folders (names that start with a .) even though iiuc Qemu MTP does advertise these files. This can confuse certain applications such as text editors or git.
- Also related, file editors typically run fsync when saving. Depending on the MTP client, it may choose not to implement it (such as simple-mtpfs that runs on top of fuse).
- Needs more testing :)

Bandan Das (5):
usb-mtp: Add one more argument when building results
usb-mtp: print parent path in IN_IGNORED trace fn
usb-mtp: Support delete of mtp objects
usb-mtp: Introduce write support for MTP objects
usb-mtp: Advertise SendObjectInfo for write support

 hw/usb/dev-mtp.c | 471 +++++++++++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 441 insertions(+), 30 deletions(-)
Signature · 1 line
2.14.3