Skip to content

net: dsa: b53/bcm_sf2 cleanups

Florian Fainelli netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 1 replyIn review
  2. v212 patches 5 repliesSuperseded
  3. v112 patches 16 repliesSuperseded

Changes in v3 from the cover letter

- remove one extra argument for the b53_build_io_op macro (David Laight)
- added additional Reviewed-by tags from Vivien

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12net: dsa: b53: Remove is_cpu_port()drivers/net/dsa/b53/b53_priv.h+0 -50 replies
2/12net: dsa: b53: Make b53_enable_cpu_port() take a port argumentdrivers/net/dsa/b53/b53_common.c+5 -60 replies
3/12net: dsa: b53: Defer port enabling to calling port_enabledrivers/net/dsa/b53/b53_common.c+5 -40 replies
4/12net: dsa: bcm_sf2: Defer port enabling to calling port_enabledrivers/net/dsa/bcm_sf2.c+3 -60 replies
5/12net: dsa: b53: Use a macro to define I/O operationsdrivers/net/dsa/b53/b53_priv.h+22 -1110 replies
6/12net: dsa: b53: Move Broadcom header setup to b53drivers/net/dsa/b53/b53_common.c drivers/net/dsa/b53/b53_priv.h drivers/net/dsa/b53/b53_regs.h +2 more+57 -490 replies
7/12net: dsa: b53: Define EEE register pagedrivers/net/dsa/b53/b53_regs.h+41 -00 replies
8/12net: dsa: b53: Move EEE functions to b53drivers/net/dsa/b53/b53_common.c drivers/net/dsa/b53/b53_priv.h drivers/net/dsa/bcm_sf2.c +2 more+74 -650 replies
9/12net: dsa: b53: Wire-up EEEdrivers/net/dsa/b53/b53_common.c+10 -00 replies
10/12net: dsa: b53: Export b53_imp_vlan_setup()drivers/net/dsa/b53/b53_common.c drivers/net/dsa/b53/b53_priv.h drivers/net/dsa/bcm_sf2.c+4 -230 replies
11/12net: dsa: bcm_sf2: Use SF2_NUM_EGRESS_QUEUES for CFPdrivers/net/dsa/bcm_sf2_cfp.c+3 -30 replies
12/12net: dsa: bcm_sf2: Utilize b53_{enable,disable}_portdrivers/net/dsa/b53/b53_common.c drivers/net/dsa/b53/b53_priv.h drivers/net/dsa/bcm_sf2.c+8 -280 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchVivien Didelot
1/12R-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b
6/12R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 00/12] net: dsa: b53/bcm_sf2 cleanups

Hi all,

This patch series is a first pass set of clean-ups to reduce the number of LOCs between b53 and bcm_sf2 and sharing as many functions as possible.

There is a number of additional cleanups queued up locally that require more thorough testing.

Thanks!

Changes in v3:

- remove one extra argument for the b53_build_io_op macro (David Laight)
- added additional Reviewed-by tags from Vivien

Changes in v2:

- added Reviewed-by tags from Vivien
- added a missing EXPORT_SYMBOL() in patch 8
- fixed a typo in patch 5

Florian Fainelli (12):
net: dsa: b53: Remove is_cpu_port()
net: dsa: b53: Make b53_enable_cpu_port() take a port argument
net: dsa: b53: Defer port enabling to calling port_enable
net: dsa: bcm_sf2: Defer port enabling to calling port_enable
net: dsa: b53: Use a macro to define I/O operations
net: dsa: b53: Move Broadcom header setup to b53
net: dsa: b53: Define EEE register page
net: dsa: b53: Move EEE functions to b53
net: dsa: b53: Wire-up EEE
net: dsa: b53: Export b53_imp_vlan_setup()
net: dsa: bcm_sf2: Use SF2_NUM_EGRESS_QUEUES for CFP
net: dsa: bcm_sf2: Utilize b53_{enable,disable}_port

 drivers/net/dsa/b53/b53_common.c | 151 ++++++++++++++++++++++++++++++++----
 drivers/net/dsa/b53/b53_priv.h   | 145 ++++++++---------------------------
 drivers/net/dsa/b53/b53_regs.h   |  48 ++++++++++++
 drivers/net/dsa/bcm_sf2.c        | 161 +++------------------------------------
 drivers/net/dsa/bcm_sf2.h        |   2 -
 drivers/net/dsa/bcm_sf2_cfp.c    |   6 +-
 drivers/net/dsa/bcm_sf2_regs.h   |  11 ---
 7 files changed, 228 insertions(+), 296 deletions(-)
Signature · 1 line
2.9.3