XFS realtime device tweaks
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest3 patches 1 replyIn review
- v6 posting 2/23 patches 1 replySuperseded
- v6 posting 1/23 patches 0 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 3 patches | 9 replies | Superseded | |
| v4 | 3 patches | 7 replies | Superseded |
Patches in v7 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | xfs: Show realtime device stats on statfs calls if realtime flags setfs/ fs/ | +10 | 1 reply | |
| 2/3 | xfs: Set realtime flag based on initial allocation sizeDocumentation/ fs/ fs/ +7 more | +178 | 0 replies | |
| 3/3 | xfs: Add realtime fallback if data device fullDocumentation/ fs/ fs/ +3 more | +118 | 0 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Christoph Hellwig | Dave Chinner | Darrick J. Wong |
|---|---|---|---|
| 1/3 | R-b | R-b | R-b |
| 2/3 | |||
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v7 0/3] XFS realtime device tweaks
This is an nearly identical patch set to the v6 patch set. The only change is a small tweak for the first patch in the series (see patch change log), and a suitable update to the commit description/title for this patch.
Patch 1 in this series is independent and can be merged before the others.
There is some feedback requested for patch 2 in this series, re-posting from v5/v6 cover letters to save some digging in your mailbox.
====
(from v5/v6 cover letter)
1. Inode flag now correctly set when locks are held via XFS_BMAPI_RTDATA flag.
2. Realtime flag is honored when set by user via ioctl or inherit flag on directory.
3. Misc changes around formatting & bounds checks on sysfs options.
See individual patches for more details.
Please pay close attention to the change in xfs_file_iomap_begin (patch 2), the new version of the patch by-passes the xfs_file_iomap_begin_delay function in the "realtime" case, since the realtime code here is not reachable/dead (see assert in this function). Instead, we by-pass this, hit xfs_iomap_write_direct where the XFS_BMAPI_RTDATA will be passed on to the xfs_bmapi_write function where it's set.
I'm curious if there is a better approach, and/or verification this is sane/safe.
Patch set based off Linux 4.14-rc8 (commit 39dae59d66acd86d1de24294bd2f343fd5e7a625) located @
https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git .
Richard Wareing (3):
xfs: Show realtime device stats on statfs calls if realtime flags set
xfs: Set realtime flag based on initial allocation size
xfs: Add realtime fallback if data device full
Documentation/filesystems/xfs.txt | 27 +++++++++++- fs/xfs/libxfs/xfs_bmap.c | 35 +++++++++++++++ fs/xfs/libxfs/xfs_bmap.h | 3 ++ fs/xfs/xfs_bmap_util.c | 3 ++ fs/xfs/xfs_fsops.c | 2 + fs/xfs/xfs_inode.c | 6 +++ fs/xfs/xfs_iomap.c | 18 +++++++- fs/xfs/xfs_linux.h | 2 + fs/xfs/xfs_mount.c | 24 +++++++++++ fs/xfs/xfs_mount.h | 8 ++++ fs/xfs/xfs_rtalloc.c | 90 +++++++++++++++++++++++++++++++++++++++ fs/xfs/xfs_rtalloc.h | 2 + fs/xfs/xfs_super.c | 8 ++++ fs/xfs/xfs_sysfs.c | 80 ++++++++++++++++++++++++++++++++++ 14 files changed, 305 insertions(+), 3 deletions(-)
Signature · 1 line
2.9.5