Skip to content

pinctrl: qcom: add support for sparse GPIOs

Stephen Boyd linux-arm-kernel linux-arm-msm linux-gpio 7 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v11 Latest posting 2/20 of 3 patches 0 repliesNew
  2. v11 posting 1/20 of 3 patches 0 repliesSuperseded
  3. v5 posting 5/50 of 2 patches 0 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v5 posting 4/50 of 2 patches0 repliesSuperseded
v5 posting 3/50 of 2 patches0 repliesSuperseded
v5 posting 2/50 of 2 patches0 repliesSuperseded
v5 posting 1/50 of 2 patches0 repliesSuperseded

Patches in v11 posting 2/2 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v11 yet.

Read the v11 thread

Cover letter [PATCH 0/3] [v11] pinctrl: qcom: add support for sparse GPIOs
Quoted 10 lines · Linus Walleij
Quoted 6 lines · Stephen Boyd

The different approaches come down to expressing
which pins are available through the gpio valid mask, or through the npins field of the msm pinctrl driver. Also, my approach covers more than just GPIOs, it covers irqs and adjusts the pinctrl pin request function so that pinctrl can't request unavailable pins.

I agree, this is better.

Thanks for the feedback. I'll update and resend my patch to the list.

Quoted 6 lines

Would even patch 1 be needed after this? Maybe I should revert that too. Leaving that code in has the upside of showing the actual initial directions of GPIO lines even if they have not been requested, in e.g. debugfs.

Patch 1 is still needed. Without that patch, we'll be poking each GPIO to figure out the direction at boot without checking any valid mask or calling the request APIs. I don't see the part in debugfs where we show the direction of a GPIO if it hasn't been requested. Don't we skip over the unrequested GPIOs because of this code in gpiolib_dbg_show()?

	if (!test_bit(FLAG_REQUESTED, &gdesc->flags)) {
		...
		continue;
	}
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Read the cover letter in its thread