Skip to content

store expression instead of data type as set key

Florian Westphal netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2evaluate: prepare to store expr key rather than datatypesrc/evaluate.c+23 -191 reply
2/2src: store expression as set key instead of data typeinclude/rule.h src/evaluate.c src/expression.c +5 more+104 -874 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPablo Neira Ayuso
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH nft 0/2] store expression instead of data type as set key

This is a prerequisite to later support dynamic data types, e.g. string, as a set key. The string datatype (and integer) do not have a fixed size, instead the size is determined by the expression.

This keeps the expression all the way down to set construction. Furthermore, in case of concatenations we can use EXPR_CONCAT to allow the netlink linearization step to determine the original sizes of the keys components.

Both changes are preparation work, they add no feature.