Skip to content

3270 improvements

Halil Pasic qemu-devel 1 version Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 14 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2s390x/3270: IDA support for 3270 via CcwDataStreamhw/char/terminal3270.c hw/s390x/3270-ccw.c include/hw/s390x/3270-ccw.h+15 -125 replies
2/2s390x/3270: handle writes of arbitrary lengthhw/char/terminal3270.c+18 -122 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchChristian BorntraegerDong Jia ShiJason J . Herne
1/2A-b R-b
2/2A-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/2] 3270 improvements

Jason found some problems with 3270 which he traced down to insufficient output buffer size. I've looked into the underlying issue (and the relevant code) and I saw strange things. Among others an unreasonable assert requiring the payload of a ccw being less than some more or less arbitrary limit (dictated by the size of the output buffer).

Because we were already considering converting 3270 to CcwDataStream I've decided to try do get rid of this strange limitation on the length of the writes too.

This series depends on my IDA work, which can be found here:
https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg03434.html.

Halil Pasic (2):
s390x/3270: IDA support for 3270 via CcwDataStream s390x/3270: handle writes of arbitrary length

 hw/char/terminal3270.c      | 46 +++++++++++++++++++++++++++------------------
 hw/s390x/3270-ccw.c         |  4 ++--
 include/hw/s390x/3270-ccw.h |  5 ++---
 3 files changed, 32 insertions(+), 23 deletions(-)
Signature · 1 line
2.13.5