Skip to content

IDE: combine portio r/w functions

John Snow qemu-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ide: generic ide_data_readhw/ide/core.c hw/ide/trace-events include/hw/ide/internal.h+49 -570 replies
2/2ide: generic ide_data_writehw/ide/core.c hw/ide/trace-events include/hw/ide/internal.h+40 -500 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/2] IDE: combine portio r/w functions

Mark, here's a quick sketch for you. There are two things I don't like, but didn't care enough to fix:

(1) Restricting nbytes to 2 or 4 means some extra boilerplate to quiet compilers who don't know it will only ever be 2 or 4
(2) the address value is all-but-ignored, it carries over from the portio signature and is useful primarily for tracing, but it's a little ugly/deceiving to take a parameter and not use it.

John Snow (2):
ide: generic ide_data_read
ide: generic ide_data_write

 hw/ide/core.c             | 185 +++++++++++++++++++++-------------------------
 hw/ide/trace-events       |   7 +-
 include/hw/ide/internal.h |   4 +-
 3 files changed, 89 insertions(+), 107 deletions(-)
Signature · 1 line
2.9.5