Skip to content

rcu/tracing/extable: Fix stack dump when RCU is not watching

Steven Rostedt lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4rcu: Allow for page faults in NMI handlerskernel/rcu/tree.c+10 -00 replies
2/4extable: Consolidate *kernel_text_address() functionskernel/extable.c+1 -91 reply
3/4extable: Enable RCU if it is not watching in kernel_text_address()kernel/extable.c+30 -54 replies
4/4tracing: Remove RCU work arounds from stack tracerkernel/trace/trace_stack.c+0 -155 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchPaul E. McKenney
1/4
2/4A-b
3/4A-b A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] rcu/tracing/extable: Fix stack dump when RCU is not watching

I'm currently running this through my test suite, but wanted to get review or acks, so that I can send this right off to Linus before rc2. I need these to base my new work on.

Basically if a stack trace happens (say from a WARN()) when RCU is not watching (like going to or coming from idle, or bringing down or up a CPU), the stack trace can cause RCU issues because it requires RCU to be watching.

We use rcu_nmi_enter() for this case, as these cases behave similar to an NMI (can happen pretty much anywhere).

Paul E. McKenney (1):
rcu: Allow for page faults in NMI handlers

Steven Rostedt (VMware) (3):
extable: Consolidate *kernel_text_address() functions
extable: Enable RCU if it is not watching in kernel_text_address()
tracing: Remove RCU work arounds from stack tracer

----

 kernel/extable.c           | 45 +++++++++++++++++++++++++++++++--------------
 kernel/rcu/tree.c          | 10 ++++++++++
 kernel/trace/trace_stack.c | 15 ---------------
 3 files changed, 41 insertions(+), 29 deletions(-)