commit: Support multiple roots above top node
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | block: Introduce BdrvChildRole.update_filenameblock.c include/ | +34 | 1 reply | |
| 2/5 | commit: Support multiple roots above top nodeblock.c block/ | +41 | 2 replies | |
| 3/5 | qemu-iotests: Allow QMP pretty printing in common.qemutests/ | +11 | 1 reply | |
| 4/5 | qemu-iotests: Test commit block job where top has two parentstests/ tests/ tests/ | +980 | 2 replies | |
| 5/5 | commit: Remove overlay_bsblock.c block/ include/ +1 more | +20 | 1 reply |
Reviews trailers per patch
3 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake |
|---|---|
| 1/5 | R-b |
| 2/5 | |
| 3/5 | R-b |
| 4/5 | |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH 0/5] commit: Support multiple roots above top node
This is a step towards making the commit job flexible enough that it can work with any kind of block graph. Currently, it requires that not only the top and base node of the commit operation are specified, but also the active layer of the backing file chain. Of course, the assumption that a single active layer exists is invalid.
This series makes the commit job consider other roots as well so that all parent nodes of the top node get their backing file updated and stay valid after the commit job completes.
With this, we should have all of the prerequisites for a follow-up series that adds a new and clean blockdev-commit QMP command which doesn't require an option for the active layer and which accepts node names instead of file names for base and top.
Kevin Wolf (5):
block: Introduce BdrvChildRole.update_filename
commit: Support multiple roots above top node
qemu-iotests: Allow QMP pretty printing in common.qemu
qemu-iotests: Test commit block job where top has two parents
commit: Remove overlay_bs
include/block/block.h | 3 +- include/block/block_int.h | 6 + block.c | 91 +++-- block/commit.c | 64 +--- tests/qemu-iotests/030 | 4 - tests/qemu-iotests/191 | 152 ++++++++ tests/qemu-iotests/191.out | 827 +++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/common.qemu | 14 +- tests/qemu-iotests/group | 1 + 9 files changed, 1078 insertions(+), 84 deletions(-) create mode 100755 tests/qemu-iotests/191 create mode 100644 tests/qemu-iotests/191.out
Signature · 1 line
2.13.5