Skip to content

IB/hfi1: IOCTL cleanup and refactoring

Dennis Dalessandro linux-rdma 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9IB/hfi1: Refactor assign_ctxt() IOCTLdrivers/infiniband/hw/hfi1/file_ops.c+19 -170 replies
2/9IB/hfi1: Refactor get_ctxt_infodrivers/infiniband/hw/hfi1/file_ops.c+10 -100 replies
3/9IB/hfi1: Fix parenthesis alignment issuesdrivers/infiniband/hw/hfi1/file_ops.c+12 -120 replies
4/9IB/hfi1: Refactor get_base_infodrivers/infiniband/hw/hfi1/file_ops.c+12 -120 replies
5/9IB/hfi1: Refactor hfi_user_exp_rcv_setup() IOCTLdrivers/infiniband/hw/hfi1/file_ops.c+45 -210 replies
6/9IB/hfi1: Refactor hfi_user_exp_rcv_clear() IOCTLsdrivers/infiniband/hw/hfi1/file_ops.c+37 -120 replies
7/9IB/hfi1: Refactor hfi_user_exp_rcv_invalid() IOCTLsdrivers/infiniband/hw/hfi1/file_ops.c drivers/infiniband/hw/hfi1/user_exp_rcv.c+40 -170 replies
8/9IB/hfi1: Refactor get_user() IOCTLsdrivers/infiniband/hw/hfi1/file_ops.c+34 -400 replies
9/9IB/hfi1: Refactor reset_ctxt() IOCTLdrivers/infiniband/hw/hfi1/file_ops.c+66 -560 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchIra Weiny
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH for-next 0/9] IB/hfi1: IOCTL cleanup and refactoring

Hi Doug,

Here is a set of patches that does some code rework to our IOCTL handling from Mike. I have bundled it as a separate series to make handling review feedback easier.

The HFI1 ioctl() function is long and complex. To reduce that complexity the following patch set refactors each IOCTL into a common pattern, and where necessary calls an associated function to handle the specific IOCTL.

Patches can can also be found in my GitHub repo at:
https://github.com/ddalessa/kernel/tree/for-4.15

---

Michael J. Ruhl (9):
IB/hfi1: Refactor assign_ctxt() IOCTL IB/hfi1: Refactor get_ctxt_info
IB/hfi1: Fix parenthesis alignment issues IB/hfi1: Refactor get_base_info
IB/hfi1: Refactor hfi_user_exp_rcv_setup() IOCTL IB/hfi1: Refactor hfi_user_exp_rcv_clear() IOCTLs IB/hfi1: Refactor hfi_user_exp_rcv_invalid() IOCTLs IB/hfi1: Refactor get_user() IOCTLs IB/hfi1: Refactor reset_ctxt() IOCTL

 drivers/infiniband/hw/hfi1/file_ops.c     |  463 +++++++++++++++++------------
 drivers/infiniband/hw/hfi1/user_exp_rcv.c |    3 
 2 files changed, 272 insertions(+), 194 deletions(-)

--
-Denny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html