Skip to content

Quirks cleanup and hid-generic niceness

Fedora Kernel Team linux-bluetooth linux-input lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4HID: core: move the dynamic quirks handling in coredrivers/hid/Makefile drivers/hid/hid-core.c drivers/hid/hid-quirks.c +4 more+414 -4160 replies
2/4HID: quirks: move the list of special devices into a quirkdrivers/hid/hid-core.c drivers/hid/hid-quirks.c include/linux/hid.h +1 more+546 -5400 replies
3/4HID: core: move the list of ignored devices in hid-quirks.cdrivers/hid/hid-core.c drivers/hid/hid-quirks.c+312 -3090 replies
4/4HID: core: remove the absolute need of hid_have_special_driver[]drivers/hid/hid-core.c drivers/hid/hid-generic.c include/linux/hid.h+125 -290 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Quirks cleanup and hid-generic niceness

From: Benjamin Tissoires <[email protected]>

Hi,

This is the series I was talking about earlier[1].

Basically, Jiri, I'd like to see 1-3 applied in for-next at your earliest convenience, and we can discuss about 4/4 without any rush.

I have this in my local tree since June, but I made some late minute changes before sending, though the tests showed they are fine (I wouldn't mind a second pair of eyes on it).

I am pretty sure we can optimize the things more, but for now this should be just fine and just convert the quirks mechanism in hid-core.
For instance, there is a second call of hid_lookup_quirk() in usbhid/hid-core.c that I am not sure about the absolute need.

Niels, please have a look at this and tell me if you are OK to rebase your series on top of it.

Cheers,
Benjamin

[1] https://patchwork.kernel.org/patch/9980443/

Benjamin Tissoires (4):
HID: core: move the dynamic quirks handling in core
HID: quirks: move the list of special devices into a quirk
HID: core: move the list of ignored devices in hid-quirks.c
HID: core: remove the absolute need of hid_have_special_driver[]

 drivers/hid/Makefile            |    2 +-
 drivers/hid/hid-core.c          |  925 ++---------------------------
 drivers/hid/hid-generic.c       |   68 ++-
 drivers/hid/hid-quirks.c        | 1242 +++++++++++++++++++++++++++++++++++++++
 drivers/hid/usbhid/Makefile     |    2 +-
 drivers/hid/usbhid/hid-core.c   |   10 +-
 drivers/hid/usbhid/hid-quirks.c |  401 -------------
 include/linux/hid.h             |   21 +-
 net/bluetooth/hidp/core.c       |    2 +-
 9 files changed, 1388 insertions(+), 1285 deletions(-)
 create mode 100644 drivers/hid/hid-quirks.c
 delete mode 100644 drivers/hid/usbhid/hid-quirks.c
Signature · 1 line
2.9.5