xfs: test support for xattr inactivate
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | xfs: assert that xattr inactivation never reaches a holefs/ | +1 | 4 replies | |
| 2/2 | xfs: buffer lru reference count error injection tagfs/ fs/ fs/ +1 more | +23 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Darrick J. Wong |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] xfs: test support for xattr inactivate
Hi all,
This series adds some testability to the issue fixed by "xfs: reinit btree pointer on attr tree inactivation walk." Patch 1 adds an assert and patch 2 adds an error injection tag to disable buffer LRU caching. I have an xfstests test that reproduces the aforementioned problem reliably using the error injection tag.
Note that patch 1 is kind of a cautious attempt to detect the issue. I'm wondering if the better fix is to pass -1 if we indeed should not ever expect to hit a hole in this particular path. Thoughts?
Brian
Brian Foster (2):
xfs: assert that xattr inactivation never reaches a hole
xfs: buffer lru reference count error injection tag
fs/xfs/xfs_attr_inactive.c | 1 + fs/xfs/xfs_buf.c | 16 ++++++++++++++++ fs/xfs/xfs_buf.h | 5 +---- fs/xfs/xfs_error.c | 3 +++ fs/xfs/xfs_error.h | 4 +++- 5 files changed, 24 insertions(+), 5 deletions(-)
Signature · 1 line
2.9.5