Skip to content

snwprintf() => _snwprintf()

[email protected]... openvpn-devel 1 version In review

Get series with b4
b4 am [email protected]...

Versions newest first

  1. v1 Latest13 patches 43 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13snwprintf() => _snwprintf()src/openvpnserv/interactive.c src/openvpnserv/validate.c+7 -76 replies
2/13Mixing wide and regular strings in concatenations is not allowed in MSVC.src/openvpnserv/interactive.c+4 -42 replies
3/13RtlIpv6AddressToStringW() and RtlIpv4AddressToStringW() require mstcpip.hsrc/openvpnserv/interactive.c+1 -02 replies
4/13Local functions are not supported in MSVC. Bummer.src/openvpnserv/interactive.c+5 -52 replies
5/13Function prototypes are declared as "typedef <return type> (<calling convention> *type_name)(<arguments>)" in MSVC.src/openvpnserv/interactive.c+7 -74 replies
6/13openvpnserv.vcxproj project file recreated using Visual Studio 2017openvpn.sln src/openvpnserv/openvpnserv.vcxproj src/openvpnserv/openvpnserv.vcxproj.filters+57 -352 replies
7/13compat.vcxproj project file upgraded to Visual Studio 2017src/compat/compat.vcxproj src/compat/compat.vcxproj.filters+19 -210 replies
8/13MSVC meta files added to .gitignore list.gitignore+2 -01 reply
9/13Signed/unsigned warnings of MSVC resolvedsrc/openvpn/block_dns.c src/openvpnserv/automatic.c src/openvpnserv/common.c +2 more+6 -623 replies
10/13msvc-generate.vcxproj project file upgraded to Visual Studio 2017build/msvc/msvc-generate/msvc-generate.vcxproj build/msvc/msvc-generate/msvc-generate.vcxproj.filters+24 -250 replies
11/13openvpn.vcxproj temporarily disabled from building in openvpn.sln until we re-establish MSVC building for itopenvpn.sln+0 -20 replies
12/13Memory size arithmetic reviewed according to 64-bit MSVC complaintssrc/openvpnserv/automatic.c src/openvpnserv/interactive.c+14 -1212 replies
13/13x64 MSVC configurations introduced.gitignore build/msvc/msvc-generate/msvc-generate.vcxproj msvc-env.bat +3 more+186 -120 replies

Reviews trailers per patch

2 of 13 patches have a Reviewed-by or Acked-by.

PatchSelva NairGert Doering
1/13
2/13
3/13
4/13
5/13
6/13
7/13
8/13
9/13A-b
10/13
11/13
12/13A-b
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread