Skip to content

kvm: slot handling fixes (and small cleanups)

David Hildenbrand qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7memory: call log_start after region_addmemory.c+3 -30 replies
2/7kvm: fix alignment of ram addressaccel/kvm/kvm-all.c+2 -10 replies
3/7kvm: tolerate non-existing slot for log_start/log_stop/log_syncaccel/kvm/kvm-all.c+4 -40 replies
4/7kvm: fix error message when failing to unregister slotaccel/kvm/kvm-all.c+1 -10 replies
5/7kvm: region_add and region_del is not called on updatesaccel/kvm/kvm-all.c+1 -70 replies
6/7kvm: simplify kvm_align_section()accel/kvm/kvm-all.c+6 -120 replies
7/7memory: reuse section_from_flat_range()memory.c+2 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH v1 0/7] kvm: slot handling fixes (and small cleanups)

Hopefully this is the last bunch of fixes for the cleanup series.

1. log_start() was called before region_add(), which is wrong.
2. I messed up the calculation of the delta when aligning the ram address (maybe we should simply also use ROUND_UP there ...).
3. I think we could get log_start/log_stop/log_sync when we actually haven't registered a slot (due to trapping).
4. Some further cleanups

Available on: https://github.com/davidhildenbrand/qemu/commits/kvm_slot

@Joe, if you could retest, this would be great! I updated the branch.

David Hildenbrand (7):
memory: call log_start after region_add
kvm: fix alignment of ram address
kvm: tolerate non-existing slot for log_start/log_stop/log_sync
kvm: fix error message when failing to unregister slot
kvm: region_add and region_del is not called on updates
kvm: simplify kvm_align_section()
memory: reuse section_from_flat_range()

 accel/kvm/kvm-all.c | 39 ++++++++++++++-------------------------
 memory.c            | 16 +++++-----------
 2 files changed, 19 insertions(+), 36 deletions(-)
Signature · 1 line
2.13.5