Skip to content

IPoIB TX NAPI

Leon Romanovsky linux-rdma 1 version Applied

Status from this message: Thanks, applied (in lieu of the original patch set that I already

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyApplied

Changes in v1 from the cover letter

* Rebase to latest for-next, commit 894b82c427d0 ("Merge branch 'timer_setup' into for-next")

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3IB/ipoib: Get rid of the tx_outstanding variable in all modesdrivers/infiniband/ulp/ipoib/ipoib.h drivers/infiniband/ulp/ipoib/ipoib_cm.c drivers/infiniband/ulp/ipoib/ipoib_ib.c+10 -110 replies
2/3IB/ipoib: Use NAPI in UD/TX flowsdrivers/infiniband/ulp/ipoib/ipoib.h drivers/infiniband/ulp/ipoib/ipoib_cm.c drivers/infiniband/ulp/ipoib/ipoib_ib.c +2 more+136 -790 replies
3/3IB/ipoib: Change number of TX wqe to 64drivers/infiniband/ulp/ipoib/ipoib.h+1 -10 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchAlex Vesker
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH rdma-next v1 0/3] IPoIB TX NAPI

Changelog from v0:
* Rebase to latest for-next, commit 894b82c427d0 ("Merge branch 'timer_setup' into for-next")

----

Quoted 1 line

From Erez Shitrit <erezsh-VPRAkNaXOzVWk0Htik3J/[email protected]>

----

It is very common in modern network devices to use NAPI in RX and TX, in the UD/TX flows IPoIB uses a polling mechanism (not as it does in the CM mode).

Except of the motivation to use the same mechanism for IPoIB as for netdevices, there are number of issues in current polling mechanism:
* SKBs that are kept longer than they should be and there are applications that warn about that (some firewalls for example).
* Statistics that are not updated to the real value. It blocks support for time synchronization protocols over the IPoIB protocol, like PTP and so on.
* The TX in CM mode already uses NAPI, there is no reason to keep two different ways for TX one for UD and one for the CM.

The patches are available in the git repository at:
git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git tags/rdma-next-2017-10-19

Thanks
---------------------------------------

Erez Shitrit (3):
IB/ipoib: Get rid of the tx_outstanding variable in all modes IB/ipoib: Use NAPI in UD/TX flows
IB/ipoib: Change number of TX wqe to 64

 drivers/infiniband/ulp/ipoib/ipoib.h       |  14 ++--
 drivers/infiniband/ulp/ipoib/ipoib_cm.c    |  46 +++++-----
 drivers/infiniband/ulp/ipoib/ipoib_ib.c    | 129 +++++++++++++++++------------
 drivers/infiniband/ulp/ipoib/ipoib_main.c  |  24 ++++--
 drivers/infiniband/ulp/ipoib/ipoib_verbs.c |  17 ++--
 5 files changed, 143 insertions(+), 87 deletions(-)

--
2.14.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html