Skip to content

refactor code and mark expected switch fall-throughs

Gustavo A. R. Silva linux-hams lkml netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 13 repliesIn review
  2. v21 patch 1 replyApplied
  3. v11 patch 1 replyApplied

Changes in v3 from the cover letter

- Update subject for both patches.
- Add this cover letter as suggested by David Miller.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: netrom: mark expected switch fall-throughsnet/netrom/nr_route.c+4 -10 replies
1/2net: netrom: nr_route: refactor code in nr_add_nodenet/netrom/nr_route.c+16 -430 replies
2/2net: netrom: refactor code in nr_add_nodenet/netrom/nr_route.c+20 -439 replies
2/2net: netrom: nr_route: mark expected switch fall-throughsnet/netrom/nr_route.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] refactor code and mark expected switch fall-throughs

The aim of this patchset is firstly to refactor code in nr_route.c in order to make it easier to read and maintain and, secondly, to mark some expected switch fall-throughs in preparation to enabling -Wimplicit-fallthrough.

I have to mention that I did not implement any unit test. If someone has any suggestions on how I could test this piece of code it'd be greatly appreciated.

Thanks

Changes in v2:
- Make use of the swap macro and remove inline keyword as suggested by Walter Harms and Kevin Dawson.

Changes in v3:
- Update subject for both patches.
- Add this cover letter as suggested by David Miller.

Gustavo A. R. Silva (2):
net: netrom: nr_route: refactor code in nr_add_node
net: netrom: nr_route: mark expected switch fall-throughs

 net/netrom/nr_route.c | 62 ++++++++++++++++-----------------------------------
 1 file changed, 19 insertions(+), 43 deletions(-)
Signature · 1 line
2.7.4