Skip to content

Various improvements/bugfixes to submodule handling

Daniel P. Berrange qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 20 repliesIn review
  2. v24 patches 15 repliesSuperseded
  3. v11 patch 3 repliesSuperseded

Changes in v3 from the cover letter

- Avoid use of mktemp
- Use '=' instead of '==' (bashism) in conditional tests
- Fix problem with short-circuiting for empty submodule list
- Ensure help message is displayed on all errors

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5build: allow setting a custom GIT binary for transparent proxyingMakefile configure scripts/git-submodule.sh+31 -71 reply
2/5build: don't create temporary files in source dirscripts/git-submodule.sh+3 -41 reply
3/5build: allow automatic git submodule updates to be disabledMakefile configure scripts/git-submodule.sh+27 -01 reply
4/5build: don't fail if given a git submodule which does not existscripts/git-submodule.sh+14 -21 reply
5/5build: delay check for empty git submodule listscripts/git-submodule.sh+12 -79 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchEric BlakePhilippe Mathieu-Daudé
SeriesT-b
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/5] Various improvements/bugfixes to submodule handling

This short series of patches improves the reliability of the submodule handling to cope with various dev env scenarios that have since emerged

v2: https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg06272.html

Changed in v3:

- Avoid use of mktemp
- Use '=' instead of '==' (bashism) in conditional tests
- Fix problem with short-circuiting for empty submodule list
- Ensure help message is displayed on all errors

Daniel P. Berrange (5):
build: allow setting a custom GIT binary for transparent proxying
build: don't create temporary files in source dir
build: allow automatic git submodule updates to be disabled
build: don't fail if given a git submodule which does not exist
build: delay check for empty git submodule list

 Makefile                 | 15 ++++++++--
 configure                | 12 ++++++++
 scripts/git-submodule.sh | 72 ++++++++++++++++++++++++++++++++++++++----------
 3 files changed, 83 insertions(+), 16 deletions(-)
Signature · 1 line
2.13.6