Skip to content

net: bcmgenet: start/stop sequence refinement

Doug Berger lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9net: bcmgenet: correct bad mergedrivers/net/ethernet/broadcom/genet/bcmgenet.c+1 -170 replies
2/9net: bcmgenet: prevent duplicate calls of bcmgenet_dma_teardowndrivers/net/ethernet/broadcom/genet/bcmgenet.c+1 -30 replies
3/9net: bcmgenet: enable loopback during UniMAC sw_resetdrivers/net/ethernet/broadcom/genet/bcmgenet.c+10 -450 replies
4/9net: bcmgenet: move NAPI initialization to ring initializationdrivers/net/ethernet/broadcom/genet/bcmgenet.c+8 -340 replies
5/9net: bcmgenet: cleanup ring interrupt masking and unmaskingdrivers/net/ethernet/broadcom/genet/bcmgenet.c+5 -230 replies
6/9net: bcmgenet: rework bcmgenet_netif_start and bcmgenet_netif_stopdrivers/net/ethernet/broadcom/genet/bcmgenet.c+17 -320 replies
7/9net: bcmgenet: relax lock constraints to reduce IRQ latencydrivers/net/ethernet/broadcom/genet/bcmgenet.c+10 -150 replies
8/9Revert "net: bcmgenet: Software reset EPHY after power on"drivers/net/ethernet/broadcom/genet/bcmgenet.c drivers/net/ethernet/broadcom/genet/bcmgenet.h drivers/net/ethernet/broadcom/genet/bcmmii.c+0 -180 replies
9/9net: bcmgenet: use dev->phydev instead of priv->phydevdrivers/net/ethernet/broadcom/genet/bcmgenet.c drivers/net/ethernet/broadcom/genet/bcmgenet.h drivers/net/ethernet/broadcom/genet/bcmmii.c+31 -340 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/9] net: bcmgenet: start/stop sequence refinement

This commit set is the result of an investigation into an issue that occurred when bringing the interface up and down repeatedly with an external 100BASE-T PHY. In some cases the MAC would experience mass receive packet duplication that could in rare cases lead to a stall from overflow. The fix for this is contained in the third commit.

The first 3 commits represent bug fixes that should be applied to the net repository and are candidates for backporting to stable releases. The remaining commits are enhancements which is why the set is being submitted to net-next but they are implemented on top of the fixes.

The first fix is provided as justification for why the set isn't split between a net submission and a net-next submission.

Doug Berger (9):
net: bcmgenet: correct bad merge
net: bcmgenet: prevent duplicate calls of bcmgenet_dma_teardown
net: bcmgenet: enable loopback during UniMAC sw_reset
net: bcmgenet: move NAPI initialization to ring initialization
net: bcmgenet: cleanup ring interrupt masking and unmasking
net: bcmgenet: rework bcmgenet_netif_start and bcmgenet_netif_stop
net: bcmgenet: relax lock constraints to reduce IRQ latency Revert "net: bcmgenet: Software reset EPHY after power on"
net: bcmgenet: use dev->phydev instead of priv->phydev

 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 269 +++++++------------------
 drivers/net/ethernet/broadcom/genet/bcmgenet.h |   2 -
 drivers/net/ethernet/broadcom/genet/bcmmii.c   |  33 +--
 3 files changed, 83 insertions(+), 221 deletions(-)
Signature · 1 line
2.14.1