Skip to content

color-moved: ignore all space changes by default

Stefan Beller git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2diff: decouple white space treatment for move detection from generic optionDocumentation/diff-options.txt diff.c diff.h +1 more+172 -90 replies
2/2diff.c: ignore all white space changes by default in the move detectionDocumentation/diff-options.txt diff.c t/t4015-diff-whitespace.sh+10 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] color-moved: ignore all space changes by default

On Mon, Oct 23, 2017 at 7:52 PM, Stefan Beller <[email protected]> wrote[1]:

Quoted 9 lines · Junio C Hamano
Quoted 4 lines

* As moved-lines display is mostly a presentation thing, I wonder if it makes sense to always match loosely wrt whitespace differences.

Well, sometimes the user wants to know if it is byte-for-byte identical (unlikely to be code, but maybe column oriented data for input; think of all our FORTRAN users. ;)

... and this is the implementation and the flip of the default setting to ignore all white space for the move detection.

It applies on "v3 (x)diff cleanup: remove duplicate code" [2].

Thanks,
Stefan

[1] https://public-inbox.org/git/CAGZ79kbba9KuDX7HsxhW3jXs7ocWfZg=KSHE-GsXjntnT4PWdg@mail.gmail.com
[2] https://public-inbox.org/git/[email protected]/

Stefan Beller (2):
diff: decouple white space treatment for move detection from generic
option
diff.c: ignore all white space changes by default in the move
detection

 Documentation/diff-options.txt |  15 ++++
 diff.c                         |  18 ++++-
 diff.h                         |   1 +
 t/t4015-diff-whitespace.sh     | 156 +++++++++++++++++++++++++++++++++++++++--
 4 files changed, 181 insertions(+), 9 deletions(-)
Signature · 1 line
2.15.0.rc2.6.g953226eb5f