Skip to content

Expose CQ moderation to user space

Leon Romanovsky linux-rdma 2 versions – Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 1 replyApplied
  2. v16 patches 17 repliesSuperseded

Changes in v2 from the cover letter

* Replaced word cookie to be CQE in commit messages.
* Added patch to rename ib_modify_cq() to be rdma_set_moderation()

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/7IB/uverbs: Allow CQ moderation with modify CQdrivers/infiniband/core/uverbs.h drivers/infiniband/core/uverbs_cmd.c drivers/infiniband/core/uverbs_main.c +2 more+62 -10 replies
2/7IB/mlx4: Exposing modify CQ callback to uverbs layerdrivers/infiniband/hw/mlx4/main.c drivers/infiniband/hw/mlx4/mlx4_ib.h include/linux/mlx4/cq.h+7 -00 replies
3/7IB/mlx5: Exposing modify CQ callback to uverbs layerdrivers/infiniband/hw/mlx5/cq.c drivers/infiniband/hw/mlx5/main.c include/linux/mlx5/cq.h+8 -10 replies
4/7IB/uverbs: Add CQ moderation capability to query_devicedrivers/infiniband/core/uverbs_cmd.c include/rdma/ib_verbs.h include/uapi/rdma/ib_user_verbs.h+22 -00 replies
5/7IB/mlx4: Add CQ moderation capability to query_devicedrivers/infiniband/hw/mlx4/main.c+3 -00 replies
6/7IB/mlx5: Add CQ moderation capability to query_devicedrivers/infiniband/hw/mlx5/main.c+7 -00 replies
7/7RDMA/core: Rename kernel modify_cq to better describe its usagedrivers/infiniband/core/uverbs_cmd.c drivers/infiniband/core/verbs.c drivers/infiniband/ulp/ipoib/ipoib_ethtool.c +1 more+8 -70 replies

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by.

PatchMajd Dibbiny
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH rdma-next v2 0/7] Expose CQ moderation to user space

Changelog:
v1->v2:
* Replaced word cookie to be CQE in commit messages.
* Added patch to rename ib_modify_cq() to be rdma_set_moderation()
v0->v1:
* Dropped comp_mask, there is already attr_mask
* Put CQ moderartion into special struct instead of general struct
* ib_uverbs_ex_modify_cq

------------------------------------------------------------------------------
This patch set exposes CQ moderation. This will allow to moderate number of CQEs needed to create an event. Such change brings performance improvement by reducing pressure on application to receive event per-CQE.

The proposed semantics follows the well-established kernel semantics.
* cq_max_count - defines the number of cookies needed to create an event. * cq_period - defines the timeout between last event and a new one
that will occur even if cq_max_count was not reached

The patches are available in the git repository at:
git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git tags/rdma-next-2017-11-13

Thanks
---------------------------------------

Leon Romanovsky (1):
RDMA/core: Rename kernel modify_cq to better describe its usage

Yonatan Cohen (6):
IB/uverbs: Allow CQ moderation with modify CQ IB/mlx4: Exposing modify CQ callback to uverbs layer IB/mlx5: Exposing modify CQ callback to uverbs layer IB/uverbs: Add CQ moderation capability to query_device IB/mlx4: Add CQ moderation capability to query_device IB/mlx5: Add CQ moderation capability to query_device

 drivers/infiniband/core/uverbs.h             |  1 +
 drivers/infiniband/core/uverbs_cmd.c         | 51 ++++++++++++++++++++++++++++
 drivers/infiniband/core/uverbs_main.c        |  1 +
 drivers/infiniband/core/verbs.c              |  4 +--
 drivers/infiniband/hw/mlx4/main.c            |  6 ++++
 drivers/infiniband/hw/mlx4/mlx4_ib.h         |  1 +
 drivers/infiniband/hw/mlx5/cq.c              |  3 ++
 drivers/infiniband/hw/mlx5/main.c            | 10 +++++-
 drivers/infiniband/ulp/ipoib/ipoib_ethtool.c |  5 +--
 include/linux/mlx4/cq.h                      |  3 ++
 include/linux/mlx5/cq.h                      |  3 ++
 include/rdma/ib_verbs.h                      | 14 ++++++--
 include/uapi/rdma/ib_user_verbs.h            | 22 +++++++++++-
 13 files changed, 116 insertions(+), 8 deletions(-)

--
2.15.0

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html