mkfs: Fix minimal device check so that reported
Status from this message: Applied, thanks.
Get series with b4
b4 am [email protected]Versions newest first
Changes in v4 from the cover letter
Further split run_mustfail_stdout() and prepare_test_dev() modification into separate patch.
Include the real mkfs fix into patchset, to prevent possible test failure.
Use suggestion from David to use run_check_mount_test_dev() and run_check_umount_test_dev().
Add "-b $good_size" to mkfs command line, so we can see the size in test result, to help further debugging.
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | btrfs-progs: mkfs: Enhance minimal device size calculation to fix mkfs failure on small filemkfs/ mkfs/ mkfs/ | +65 | 3 replies | |
| 2/4 | btrfs-progs: test/common: Introduce run_mustfail_stdouttests/ | +52 | 1 reply | |
| 3/4 | btrfs-progs: test/common: Enhance prepare_test_dev to reset device sizetests/ | +5 | 1 reply | |
| 4/4 | btrfs-progs: test/mkfs: Test if the minimal device size is validtests/ | +49 | 1 reply |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by.
| Patch | Lu Fengqi |
|---|---|
| 1/4 | R-b |
| 2/4 | |
| 3/4 | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/4] mkfs: Fix minimal device check so that reported
Original reported by Wesley AC:
https://github.com/kdave/btrfs-progs/issues/70
Fix it by taking data/meta profile and minimal chunk size into consideration.
Also introduce a test case for that.
Changelog:
v2:
Refactor test_minimum_size() to take @min_dev_size directly. Refactor patch already in devel branch.
v3:
Split test/common modification into separate patch.
v4:
Further split run_mustfail_stdout() and prepare_test_dev() modification into separate patch.
Include the real mkfs fix into patchset, to prevent possible test failure.
Use suggestion from David to use run_check_mount_test_dev() and run_check_umount_test_dev().
Add "-b $good_size" to mkfs command line, so we can see the size in test result, to help further debugging.
Qu Wenruo (4):
btrfs-progs: mkfs: Enhance minimal device size calculation to fix mkfs
failure on small file
btrfs-progs: test/common: Introduce run_mustfail_stdout
btrfs-progs: test/common: Enhance prepare_test_dev to reset device
size
btrfs-progs: test/mkfs: Test if the minimal device size is valid
mkfs/common.c | 68 ++++++++++++++++++++++++++++---- mkfs/common.h | 4 +- mkfs/main.c | 3 +- tests/common | 58 ++++++++++++++++++++++++++- tests/mkfs-tests/010-small-image/test.sh | 49 +++++++++++++++++++++++ 5 files changed, 171 insertions(+), 11 deletions(-) create mode 100755 tests/mkfs-tests/010-small-image/test.sh
Signature · 1 line
2.14.3