Skip to content

Add Headphone Detection to TLV320AIC31xx Driver

Andrew F. Davis alsa-devel lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 3 repliesIn review
  2. v219 patches 43 repliesSuperseded
  3. v117 patches 9 repliesSuperseded

Changes in v3 from the cover letter

- Rebased on -next
- Added delta patch for GPIO header fix
- Split platform data remove into fwnode and pdata removal
- Rework reset patch to print error code
- Use snd_soc_codec_set_jack to set jack

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ASoC: tlv320aic31xx: Fix GPIO header includessound/soc/codecs/tlv320aic31xx.c+1 -11 reply
2/10ASoC: tlv320aic31xx: Use fwnode APIs over raw OF callssound/soc/codecs/tlv320aic31xx.c+29 -481 reply
3/10ASoC: tlv320aic31xx: Remove platform datasound/soc/codecs/tlv320aic31xx.c sound/soc/codecs/tlv320aic31xx.h+0 -130 replies
4/10ASoC: tlv320aic31xx: Add MICBIAS off settingDocumentation/devicetree/bindings/sound/tlv320aic31xx.txt include/dt-bindings/sound/tlv320aic31xx-micbias.h sound/soc/codecs/tlv320aic31xx.c+3 -00 replies
5/10ASoC: tlv320aic31xx: Remove regulator notification handlingsound/soc/codecs/tlv320aic31xx.c+1 -560 replies
6/10ASoC: tlv320aic31xx: Reset registers during power upsound/soc/codecs/tlv320aic31xx.c+22 -41 reply
7/10ASoC: tlv320aic31xx: Add short circuit detection supportsound/soc/codecs/tlv320aic31xx.c sound/soc/codecs/tlv320aic31xx.h+58 -00 replies
8/10ASoC: tlv320aic31xx: Add overflow detection supportsound/soc/codecs/tlv320aic31xx.c sound/soc/codecs/tlv320aic31xx.h+26 -10 replies
9/10ASoC: tlv320aic31xx: Add headphone/headset detectionsound/soc/codecs/tlv320aic31xx.c sound/soc/codecs/tlv320aic31xx.h+56 -00 replies
10/10ASoC: tlv320aic31xx: Add button press detectionsound/soc/codecs/tlv320aic31xx.c sound/soc/codecs/tlv320aic31xx.h+15 -20 replies

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by.

PatchRob Herring
1/10
2/10
3/10
4/10A-b
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/10] Add Headphone Detection to TLV320AIC31xx Driver

Hello all,

This series has the end goal of adding headphone detection to the tlv320aic31xx driver. The first few patches are mostly cleanups. Then a couple bug fixes I noticed. Followed by adding interrupt handling and finally headphone detection.

Still not sure if the IRQ patch is correct, I think we have no good way to share this IRQ line, so leaving it the way it is for now.

Thanks,
Andrew

Changes from v2:
- Rebased on -next
- Added delta patch for GPIO header fix
- Split platform data remove into fwnode and pdata removal
- Rework reset patch to print error code
- Use snd_soc_codec_set_jack to set jack

Changes from v1:
- Splitup the cleanup patch a bit more
- Move the GPIO1 register fix patch before header cleanup so it can be taken back into stable
- Added Acked-by
- New patch dealing with regulator notifications
- Various small touchups
- Rebased on v4.15-rc1

Andrew F. Davis (10):
ASoC: tlv320aic31xx: Fix GPIO header includes
ASoC: tlv320aic31xx: Use fwnode APIs over raw OF calls
ASoC: tlv320aic31xx: Remove platform data
ASoC: tlv320aic31xx: Add MICBIAS off setting
ASoC: tlv320aic31xx: Remove regulator notification handling
ASoC: tlv320aic31xx: Reset registers during power up
ASoC: tlv320aic31xx: Add short circuit detection support
ASoC: tlv320aic31xx: Add overflow detection support
ASoC: tlv320aic31xx: Add headphone/headset detection
ASoC: tlv320aic31xx: Add button press detection

 .../devicetree/bindings/sound/tlv320aic31xx.txt    |   1 +
 include/dt-bindings/sound/tlv320aic31xx-micbias.h  |   1 +
 sound/soc/codecs/tlv320aic31xx.c                   | 263 +++++++++++++--------
 sound/soc/codecs/tlv320aic31xx.h                   |  41 +++-
 4 files changed, 196 insertions(+), 110 deletions(-)
Signature · 1 line
2.15.0