Skip to content

blame: (dim rep. metadata lines or fields, decay date coloring)

Stefan Beller git 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 7 repliesIn review
  2. v24 patches 7 repliesSuperseded
  3. v1 RFC4 patches 0 repliesSuperseded

v2 from the cover letter

This is picking up [1], but presenting it in another approach, as I realized these are orthogonal features:
* dimming repeated lines/fields of information
* giving a quick visual information how old (as a proxy for 'well tested') a line of code is.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4color.h: document and modernize headercolor.c color.h+44 -161 reply
2/4builtin/blame: dim uninteresting metadataDocumentation/config.txt builtin/blame.c color.h +1 more+60 -142 replies
3/4builtin/blame: add option to color metadata fields separatelybuiltin/blame.c t/t8012-blame-colors.sh+113 -80 replies
4/4builtin/blame: highlight recently changed linesDocumentation/config.txt builtin/blame.c+91 -12 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCHv3 0/4] blame: (dim rep. metadata lines or fields, decay date coloring)

v3:

Thanks Eric for feedback, I implemented all of the suggestions. Specifically I dropped the abstractions in patch2 but keep around a similar abstraction in patch 3 as that still looks like it benefits (the condition is just growing large).

Thanks,
Stefan

v2:
This is picking up [1], but presenting it in another approach, as I realized these are orthogonal features:
* dimming repeated lines/fields of information
* giving a quick visual information how old (as a proxy for 'well tested') a line of code is.

Both features are configurable.

Changes from sending it out in November:
* better commit messages
* rebased on master

Any feedback welcome.

Thanks,
Stefan

[1] https://public-inbox.org/git/[email protected]/

Stefan Beller (4):
color.h: document and modernize header builtin/blame: dim uninteresting metadata builtin/blame: add option to color metadata fields separately builtin/blame: highlight recently changed lines

 Documentation/config.txt |  23 ++++++
 builtin/blame.c          | 201 ++++++++++++++++++++++++++++++++++++++++++-----
 color.c                  |   2 -
 color.h                  |  59 ++++++++++----
 t/t8012-blame-colors.sh  |  56 +++++++++++++
 5 files changed, 305 insertions(+), 36 deletions(-)
 create mode 100755 t/t8012-blame-colors.sh
Signature · 1 line
2.16.0.rc0.223.g4a4ac83678-goog

Read the cover letter in its thread