intel: Use smp_rmb rather than read_barrier_depends
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v1 Latest posting 2/20 of 7 patches 0 repliesNew
- v1 posting 1/20 of 7 patches 0 repliesSuperseded
Patches in v1 posting 2/2 No applies recorded yet
None of the 7 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Intel-wired-lan] [PATCH 0/7] [RESEND] [net] intel: Use smp_rmb rather than read_barrier_depends
Quoted 9 lines · On Thu, 16 Nov 2017 14:03:02 -0600 Brian King <[email protected]> wrote:
I did think about changing the powerpc definition of
read_barrier_depends, but after reading up on that barrier, decided it was not the correct barrier to be used in this context. Here is some good historical background onread_barrier_dependsthat I found, along with an example.https://lwn.net/Articles/5159/
Since there is no data-dependency in the code in question here, I think the
smp_rmbis the proper barrier to use.
Hey Brian, thanks for the explanation, I'll agree with you and Alex that the smb_rmb replacement is okay. Does your test still pass without the ->skb NULLs?