Skip to content

Updated State of my clk patches

Karol Herbst nouveau 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest32 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/32bios/vpstate: There are some fermi vbios with no boost or tdp entrydrm/nouveau/nvkm/subdev/bios/vpstate.c+8 -22 replies
2/32debugfs: Wake up GPU before doing any reclockingdrm/nouveau/nouveau_debugfs.c+4 -02 replies
3/32therm: Split return code and value in nvkm_get_tempdrm/nouveau/include/nvkm/subdev/clk.h drm/nouveau/include/nvkm/subdev/therm.h drm/nouveau/nouveau_hwmon.c +8 more+60 -424 replies
4/32hwmon: Properly check for errorsdrm/nouveau/nouveau_hwmon.c+26 -70 replies
5/32clk: Improve names of pstate/cstate related variables and fieldsdrm/nouveau/include/nvkm/subdev/bios/boost.h drm/nouveau/include/nvkm/subdev/bios/perf.h drm/nouveau/include/nvkm/subdev/clk.h +7 more+59 -560 replies
6/32clk: Add NVKM_CLK_PSTATE_BOOTdrm/nouveau/include/nvkm/subdev/clk.h drm/nouveau/nvkm/subdev/clk/base.c+7 -50 replies
7/32clk: Rename NVKM_CLK_CSTATE_HIGHEST to NVKM_CLK_CSTATE_AUTOdrm/nouveau/include/nvkm/subdev/clk.h drm/nouveau/nvkm/subdev/clk/base.c+3 -30 replies
8/32clk: Rename nvkm_clk.states to pstatesdrm/nouveau/include/nvkm/subdev/clk.h drm/nouveau/nvkm/engine/device/ctrl.c drm/nouveau/nvkm/subdev/clk/base.c +1 more+21 -200 replies
9/32clk: Rename nvkm_pstate.list to cstatesdrm/nouveau/include/nvkm/subdev/clk.h drm/nouveau/nvkm/engine/device/ctrl.c drm/nouveau/nvkm/subdev/clk/base.c +1 more+12 -120 replies
10/32clk: Remove dstatedrm/nouveau/include/nvkm/subdev/clk.h drm/nouveau/nvkm/subdev/clk/base.c+2 -160 replies
11/32clk: Rename nvkm_pstate_calc to nvkm_clk_update and export itdrm/nouveau/include/nvkm/subdev/clk.h drm/nouveau/nvkm/subdev/clk/base.c+16 -90 replies
12/32clk: Use list_for_each_entry_from_reverse in nvkm_cstate_find_bestdrm/nouveau/nvkm/subdev/clk/base.c lib/include/nvif/list.h+9 -60 replies
13/32clk: We should pass the pstate id around not the index in the listdrm/nouveau/include/nvkm/subdev/clk.h drm/nouveau/nouveau_debugfs.c drm/nouveau/nvkm/engine/device/ctrl.c +2 more+52 -600 replies
14/32clk: Hold information about the current cstate statusdrm/nouveau/include/nvkm/subdev/clk.h drm/nouveau/nvkm/subdev/clk/base.c+10 -40 replies
15/32clk: Refactor the base and boost clock limits so that we can limit pstatesdrm/nouveau/include/nvkm/subdev/clk.h drm/nouveau/nvkm/subdev/clk/base.c+41 -190 replies
16/32therm: Move the temp readout into nvkm_therm_updatedrm/nouveau/nvkm/subdev/therm/base.c+14 -200 replies
17/32core/device: Move therm behind clkdrm/nouveau/include/nvkm/core/device.h+1 -10 replies
18/32therm: Trigger reclock in temperature daemondrm/nouveau/nvkm/subdev/therm/base.c+6 -00 replies
19/32bios: Add thermal policies tabledrm/nouveau/include/nvkm/subdev/bios/thermal_policies.h drm/nouveau/nvkm/subdev/bios/Kbuild drm/nouveau/nvkm/subdev/bios/thermal_policies.c+107 -00 replies
20/32therm: Cancel the timer only in finidrm/nouveau/nvkm/subdev/therm/base.c+7 -60 replies
21/32clk: Parse thermal policies for throttling thresholdsdrm/nouveau/include/nvkm/subdev/clk.h drm/nouveau/nvkm/subdev/clk/base.c+44 -00 replies
22/32clk: Thermal throttlingdrm/nouveau/include/nvkm/subdev/clk.h drm/nouveau/nvkm/subdev/clk/base.c+38 -100 replies
23/32clk: Skip unchanging parts of the reclockdrm/nouveau/nvkm/subdev/clk/base.c drm/nouveau/nvkm/subdev/volt/base.c+18 -80 replies
24/32clk: Save the max clock we can setdrm/nouveau/include/nvkm/subdev/clk.h drm/nouveau/nvkm/subdev/clk/base.c+3 -00 replies
25/32nvif: Add boost info and set operationsdrm/nouveau/include/nvif/if0001.h drm/nouveau/nvkm/engine/device/ctrl.c+76 -00 replies
26/32debugfs: Add boost interface to change the boost_modedrm/nouveau/nouveau_debugfs.c+81 -00 replies
27/32bios/vpstate: Parse max battery iddrm/nouveau/include/nvkm/subdev/bios/vpstate.h drm/nouveau/nvkm/subdev/bios/vpstate.c+3 -10 replies
28/32clk: Implement limiting pstates just like we do for cstatesdrm/nouveau/nvkm/subdev/clk/base.c+52 -90 replies
29/32clk: Limit clocks on batterydrm/nouveau/include/nvkm/subdev/clk.h drm/nouveau/nvkm/subdev/clk/base.c+21 -00 replies
30/32secboot/acr352: Reset PMU after secbootdrm/nouveau/nvkm/subdev/secboot/acr_r352.c+14 -00 replies
31/32device: Enable clk for Maxwell2drm/nouveau/nvkm/engine/device/base.c drm/nouveau/nvkm/subdev/clk/gk104.c+12 -10 replies
32/32clk: Add trace message when setting a new cstatedrm/nouveau/nvkm/subdev/clk/base.c+2 -00 replies

Reviews trailers per patch

11 of 32 patches have a Reviewed-by or Acked-by.

PatchPierre MoreauMartin Peres
1/32
2/32
3/32
4/32R-b
5/32
6/32
7/32
8/32
9/32
10/32R-b R-b
11/32
12/32
13/32R-b
14/32A-b R-b
15/32
16/32
17/32
18/32R-b R-b
19/32A-b
20/32R-b
21/32
22/32R-b
23/32
24/32R-b
25/32R-b
26/32R-b
27/32
28/32
29/32
30/32
31/32
32/32

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/32] Updated State of my clk patches

Last update here: https://lists.freedesktop.org/archives/nouveau/2017-September/028848.html

Basically big cleanup, reordering, simplifications and some renaming to make the code easier to read and to review. I also moved some bugfixes to the front so they can be merged prior the other patches.

There was also a bug related to the therm daemon triggering a pstate change leading to PMU lockups, because the timer wasn't disabled on fini.

I think we are getting close with this and hope we can merge this soon.

Karol Herbst (32):
bios/vpstate: There are some fermi vbios with no boost or tdp entry
debugfs: Wake up GPU before doing any reclocking
therm: Split return code and value in nvkm_get_temp
hwmon: Properly check for errors
clk: Improve names of pstate/cstate related variables and fields
clk: Add NVKM_CLK_PSTATE_BOOT
clk: Rename NVKM_CLK_CSTATE_HIGHEST to NVKM_CLK_CSTATE_AUTO
clk: Rename nvkm_clk.states to pstates
clk: Rename nvkm_pstate.list to cstates
clk: Remove dstate
clk: Rename nvkm_pstate_calc to nvkm_clk_update and export it
clk: Use list_for_each_entry_from_reverse in nvkm_cstate_find_best
clk: We should pass the pstate id around not the index in the list
clk: Hold information about the current cstate status
clk: Refactor the base and boost clock limits so that we can limit
pstates
therm: Move the temp readout into nvkm_therm_update core/device: Move therm behind clk
therm: Trigger reclock in temperature daemon
bios: Add thermal policies table
therm: Cancel the timer only in fini
clk: Parse thermal policies for throttling thresholds
clk: Thermal throttling
clk: Skip unchanging parts of the reclock
clk: Save the max clock we can set
nvif: Add boost info and set operations
debugfs: Add boost interface to change the boost_mode bios/vpstate: Parse max battery id
clk: Implement limiting pstates just like we do for cstates
clk: Limit clocks on battery
secboot/acr352: Reset PMU after secboot
device: Enable clk for Maxwell2
clk: Add trace message when setting a new cstate

 drm/nouveau/include/nvif/if0001.h                  |  15 +
 drm/nouveau/include/nvkm/core/device.h             |   2 +-
 drm/nouveau/include/nvkm/subdev/bios/boost.h       |   2 +-
 drm/nouveau/include/nvkm/subdev/bios/perf.h        |   2 +-
 .../include/nvkm/subdev/bios/thermal_policies.h    |  25 ++
 drm/nouveau/include/nvkm/subdev/bios/vpstate.h     |   1 +
 drm/nouveau/include/nvkm/subdev/clk.h              |  40 +-
 drm/nouveau/include/nvkm/subdev/therm.h            |   2 +-
 drm/nouveau/nouveau_debugfs.c                      |  99 ++++-
 drm/nouveau/nouveau_hwmon.c                        |  48 ++-
 drm/nouveau/nvkm/engine/device/base.c              |   3 +
 drm/nouveau/nvkm/engine/device/ctrl.c              |  73 +++-
 drm/nouveau/nvkm/subdev/bios/Kbuild                |   1 +
 drm/nouveau/nvkm/subdev/bios/boost.c               |  11 +-
 drm/nouveau/nvkm/subdev/bios/perf.c                |   2 +-
 drm/nouveau/nvkm/subdev/bios/thermal_policies.c    |  81 ++++
 drm/nouveau/nvkm/subdev/bios/vpstate.c             |  13 +-
 drm/nouveau/nvkm/subdev/clk/base.c                 | 427 ++++++++++++++-------
 drm/nouveau/nvkm/subdev/clk/gk104.c                |  10 +-
 drm/nouveau/nvkm/subdev/clk/gk20a.c                |   4 +-
 drm/nouveau/nvkm/subdev/pmu/gk20a.c                |   9 +-
 drm/nouveau/nvkm/subdev/secboot/acr_r352.c         |  14 +
 drm/nouveau/nvkm/subdev/therm/base.c               |  52 ++-
 drm/nouveau/nvkm/subdev/therm/g84.c                |  13 +-
 drm/nouveau/nvkm/subdev/therm/gp100.c              |   9 +-
 drm/nouveau/nvkm/subdev/therm/nv40.c               |   9 +-
 drm/nouveau/nvkm/subdev/therm/nv50.c               |   9 +-
 drm/nouveau/nvkm/subdev/therm/priv.h               |   4 +-
 drm/nouveau/nvkm/subdev/therm/temp.c               |  16 +-
 drm/nouveau/nvkm/subdev/volt/base.c                |   3 +
 lib/include/nvif/list.h                            |   5 +
 31 files changed, 758 insertions(+), 246 deletions(-)
 create mode 100644 drm/nouveau/include/nvkm/subdev/bios/thermal_policies.h
 create mode 100644 drm/nouveau/nvkm/subdev/bios/thermal_policies.c
Signature · 6 lines
2.15.0

_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau