Skip to content

ixgbe/fm10k: macvlan fixes

Alexander Duyck intel-wired-lan 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16ixgbe: Fix interaction between SR-IOV and macvlan offloaddrivers/net/ethernet/intel/ixgbe/ixgbe_main.c+5 -71 reply
2/16ixgbe: Perform reinit any time number of VFs changedrivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c+3 -161 reply
3/16ixgbe: Add support for macvlan offload RSS on X550 and clean-up pool handlingdrivers/net/ethernet/intel/ixgbe/ixgbe_main.c+25 -371 reply
4/16ixgbe: There is no need to update num_rx_pools in L2 fwd offloaddrivers/net/ethernet/intel/ixgbe/ixgbe_lib.c drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+1 -41 reply
5/16ixgbe: Fix limitations on macvlan so we can support up to 63 offloaded devicesdrivers/net/ethernet/intel/ixgbe/ixgbe.h drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +1 more+34 -431 reply
6/16ixgbe: Use ring values to test for Tx pendingdrivers/net/ethernet/intel/ixgbe/ixgbe_main.c+4 -161 reply
7/16ixgbe: Drop l2_accel_priv data pointer from ring structdrivers/net/ethernet/intel/ixgbe/ixgbe.h drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+13 -111 reply
8/16ixgbe: Assume provided MAC filter has been verified by macvlandrivers/net/ethernet/intel/ixgbe/ixgbe_main.c+8 -41 reply
9/16ixgbe: Default to 1 pool always being allocateddrivers/net/ethernet/intel/ixgbe/ixgbe_main.c drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c+3 -51 reply
10/16ixgbe: Don't assume dev->num_tc is equal to hardware TC configdrivers/net/ethernet/intel/ixgbe/ixgbe.h drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c +3 more+29 -271 reply
11/16ixgbe/fm10k: Record macvlan stats instead of Rx queue for macvlan offloaded ringsdrivers/net/ethernet/intel/fm10k/fm10k_main.c drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+14 -101 reply
12/16ixgbe: Do not manipulate macvlan Tx queues when performing macvlan offloaddrivers/net/ethernet/intel/ixgbe/ixgbe_lib.c drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+25 -1081 reply
13/16ixgbe: avoid bringing rings up/down as macvlans are added/removeddrivers/net/ethernet/intel/ixgbe/ixgbe_lib.c drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+72 -581 reply
14/16ixgbe: Fix handling of macvlan Tx offloaddrivers/net/ethernet/intel/ixgbe/ixgbe_lib.c drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+14 -101 reply
15/16net: Cap number of queues even with accel_privnet/core/dev.c+1 -21 reply
16/16fm10k: Fix configuration for macvlan offloaddrivers/net/ethernet/intel/fm10k/fm10k_netdev.c+22 -31 reply

Reviews trailers per patch

None of the 16 patches has a Reviewed-by or Acked-by.

PatchAndrew BowersKrishneil Singh
1/16T-b
2/16T-b
3/16T-b
4/16T-b
5/16T-b
6/16T-b
7/16T-b
8/16T-b
9/16T-b
10/16T-b
11/16T-b
12/16T-b
13/16T-b
14/16T-b
15/16T-b
16/16T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Intel-wired-lan] [jkirsher/next-queue PATCH 00/16] ixgbe/fm10k: macvlan fixes

This patch series is meant to make it so that both fm10k and ixgbe drivers will at least function when macvlan offload is enabled. Prior to these patches both fm10k and ixgbe had numerous issues that had a negative impact on driver stability with the offload enabled, or in the case of fm10k the interfaces would never actually receive any traffic as the filters were never configured correctly.

There are still a few issues outstanding after these patches, but I needed to flush out what I had before this patch set became too large.

The next set of patches will include changes to the macvlan interface itself and so I thought that would make a good division between this patch set and the one to follow.

---

Alexander Duyck (16):
ixgbe: Fix interaction between SR-IOV and macvlan offload
ixgbe: Perform reinit any time number of VFs change
ixgbe: Add support for macvlan offload RSS on X550 and clean-up pool handling
ixgbe: There is no need to update num_rx_pools in L2 fwd offload
ixgbe: Fix limitations on macvlan so we can support up to 63 offloaded devices
ixgbe: Use ring values to test for Tx pending
ixgbe: Drop l2_accel_priv data pointer from ring struct
ixgbe: Assume provided MAC filter has been verified by macvlan
ixgbe: Default to 1 pool always being allocated
ixgbe: Don't assume dev->num_tc is equal to hardware TC config ixgbe/fm10k: Record macvlan stats instead of Rx queue for macvlan offloaded rings
ixgbe: Do not manipulate macvlan Tx queues when performing macvlan offload
ixgbe: avoid bringing rings up/down as macvlans are added/removed
ixgbe: Fix handling of macvlan Tx offload
net: Cap number of queues even with accel_priv
fm10k: Fix configuration for macvlan offload

 drivers/net/ethernet/intel/fm10k/fm10k_main.c    |   14 -
 drivers/net/ethernet/intel/fm10k/fm10k_netdev.c  |   25 +
 drivers/net/ethernet/intel/ixgbe/ixgbe.h         |    8 
 drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c  |    2 
 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c |    6 
 drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c     |   72 ++--
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c    |  407 ++++++++--------------
 drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c   |   63 +--
 net/core/dev.c                                   |    3 
 9 files changed, 256 insertions(+), 344 deletions(-)

--