fix bitmaps migration through shared storage
Status from this message: Thanks, applied to my block branch:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest3 patches 13 repliesApplied
- v33 patches 5 repliesSuperseded
- v23 patches 9 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 9 replies | Superseded |
v2 from the cover letter
John, thank you for reviewing v1.
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | qcow2-bitmap: add qcow2_reopen_bitmaps_rw_hint()block/ block/ | +16 | 0 replies | |
| 2/3 | qcow2: fix bitmaps loading when bitmaps already existblock/ | +16 | 0 replies | |
| 2/3 | qcow2: handle reopening bitmaps on bdrv_invalidate_cacheblock/ | +16 | 1 reply | |
| 3/3 | iotests: enable shared migration cases in 169tests/ tests/ | +5 | 0 replies |
Reviews trailers per patch
1 of 4 patches has a Reviewed-by or Acked-by.
| Patch | John Snow | Max Reitz |
|---|---|---|
| 1/3 | R-b | R-b |
| 2/3 | ||
| 2/3 | ||
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage
Hi all.
This fixes bitmaps migration through shared storage. Look at 02 for details.
The bug introduced in 2.10 with the whole qcow2 bitmaps feature, so qemu-stable in CC. However I doubt that someone really suffered from this.
Do we need dirty bitmaps at all in inactive case? - that was a question in v2. And, keeping in mind that we are going to use inactive mode not only for incoming migration, I'm not sure that answer is NO (but, it may be "NO" for 2.10, 2.11), so let's fix it in proposed here manner at least for 2.12.
v4:
01: r-b: Max
02: rewrite to do not load bitmaps if any bitmaps alredy exit, drop r-b 03: add missed change of 169.out
v3: tiny context changes in 01,02
03: instead of a separate test, enable corresponding case in existent one
v2:
John, thank you for reviewing v1.
changes:
add John's r-bs, change s/timeout=10/timeout=10.0/ in last patch and drop old 03 patch, related to this timeout fix.
Vladimir Sementsov-Ogievskiy (3):
qcow2-bitmap: add qcow2_reopen_bitmaps_rw_hint()
qcow2: fix bitmaps loading when bitmaps already exist
iotests: enable shared migration cases in 169
block/qcow2.h | 2 ++ block/qcow2-bitmap.c | 15 ++++++++++++++- block/qcow2.c | 17 ++++++++++++++++- tests/qemu-iotests/169 | 8 +++----- tests/qemu-iotests/169.out | 4 ++-- 5 files changed, 37 insertions(+), 9 deletions(-)
Signature · 1 line
2.11.1